Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@oodt.apache.org
Received-SPF: pass (athena.apache.org: local policy)
From: "Cinquini, Luca (3880)" <Luca.Cinquini@jpl.nasa.gov>
To: "<dev@oodt.apache.org>" <dev@oodt.apache.org>
Subject: Re: svn commit: r1343834 -
 /oodt/trunk/opendapps/src/main/java/org/apache/oodt/opendapps/OpendapProfileElementExtractor.java
Thread-Topic: svn commit: r1343834 -
 /oodt/trunk/opendapps/src/main/java/org/apache/oodt/opendapps/OpendapProfileElementExtractor.java
Thread-Index: AQHNPbmxCefzMXqe8UKu5yZ1gwirBpbiE16AgAConwA=
Date: Wed, 30 May 2012 12:38:02 +0000
Message-ID: <0444E728-B2F3-4B69-9D98-44D09425D15D@jpl.nasa.gov>
References: <20120529163935.5E87A2388978@eris.apache.org>
 <077B5C32-3B1C-4DE0-BEF5-BFCBE4D863E2@jpl.nasa.gov>
In-Reply-To: <077B5C32-3B1C-4DE0-BEF5-BFCBE4D863E2@jpl.nasa.gov>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BDAD3C1B0ADBBD42AA6B7F05C55019FF@ad.jpl>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi Chris,
	not really because this was really a small bug that I found - do we need t=
o file tickets for every single commit ? (if so, no problem).
I do have some bigger items coming up that need Jira tickets, in-fact I'll =
file these soon.
thanks, Luca

On May 29, 2012, at 8:34 PM, Mattmann, Chris A (388J) wrote:

> Hey Luca,
>=20
> Did you file an issue in JIRA for the below or was it related to one?=20
>=20
> Thanks,
> Chris
>=20
> On May 29, 2012, at 9:39 AM, <luca@apache.org>
> <luca@apache.org> wrote:
>=20
>> Author: luca
>> Date: Tue May 29 16:39:34 2012
>> New Revision: 1343834
>>=20
>> URL: http://svn.apache.org/viewvc?rev=3D1343834&view=3Drev
>> Log:
>> Protecting metadata extraction versus attributes that are containers
>>=20
>> Modified:
>>   oodt/trunk/opendapps/src/main/java/org/apache/oodt/opendapps/OpendapPr=
ofileElementExtractor.java
>>=20
>> Modified: oodt/trunk/opendapps/src/main/java/org/apache/oodt/opendapps/O=
pendapProfileElementExtractor.java
>> URL: http://svn.apache.org/viewvc/oodt/trunk/opendapps/src/main/java/org=
/apache/oodt/opendapps/OpendapProfileElementExtractor.java?rev=3D1343834&r1=
=3D1343833&r2=3D1343834&view=3Ddiff
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- oodt/trunk/opendapps/src/main/java/org/apache/oodt/opendapps/Opendap=
ProfileElementExtractor.java (original)
>> +++ oodt/trunk/opendapps/src/main/java/org/apache/oodt/opendapps/Opendap=
ProfileElementExtractor.java Tue May 29 16:39:34 2012
>> @@ -68,32 +68,38 @@ public class OpendapProfileElementExtrac
>>    while (attributeNames.hasMoreElements()) {
>>      String attrName =3D (String) attributeNames.nextElement();
>>      Attribute attr =3D attTable.getAttribute(attrName);
>> -      Enumeration attrValues =3D null;
>> -      try {
>> -        attrValues =3D attr.getValues();
>> -      } catch (NoSuchAttributeException e) {
>> -        e.printStackTrace();
>> -        LOG.log(Level.WARNING, "Attempt to resolve attribute: [" + attr=
Name
>> -            + "] failed: Message: " + e.getMessage());
>> -        continue;
>> -      }
>> -
>> -      while (attrValues.hasMoreElements()) {
>> -        String attrValue =3D (String) attrValues.nextElement();
>> -        if (attrName.equals(ACTUAL_RANGE)) {
>> -          elem.setMinValue(attrValue);
>> -          if (attrValues.hasMoreElements()) {
>> -            elem.setMaxValue((String) attrValues.nextElement());
>> +    =20
>> +      if (!attr.isContainer()) {
>> +      	 Enumeration attrValues =3D null;
>> +       =20
>> +        	try {
>> +            attrValues =3D attr.getValues();
>> +          } catch (NoSuchAttributeException e) {
>> +            e.printStackTrace();
>> +            LOG.log(Level.WARNING, "Attempt to resolve attribute: [" + =
attrName
>> +                + "] failed: Message: " + e.getMessage());
>> +            continue;
>> +         }
>> + =20
>> +        while (attrValues.hasMoreElements()) {
>> +          String attrValue =3D (String) attrValues.nextElement();
>> +          if (attrName.equals(ACTUAL_RANGE)) {
>> +            elem.setMinValue(attrValue);
>> +            if (attrValues.hasMoreElements()) {
>> +              elem.setMaxValue((String) attrValues.nextElement());
>> +            }
>> +          } else if (attrName.equals(UNITS)) {
>> +            elem.setUnit(attrValue);
>> +          } else if (attrName.equals(START)) {
>> +            elem.setMinValue(attrValue);
>> +          } else if (attrName.equals(END)) {
>> +            elem.setMaxValue(attrValue);
>>          }
>> -        } else if (attrName.equals(UNITS)) {
>> -          elem.setUnit(attrValue);
>> -        } else if (attrName.equals(START)) {
>> -          elem.setMinValue(attrValue);
>> -        } else if (attrName.equals(END)) {
>> -          elem.setMaxValue(attrValue);
>>        }
>>      }
>> -    }
>> +     =20
>> +    } // not a container attribute
>> +   =20
>>    return elem;
>>  }
>>=20
>>=20
>>=20
>=20
>=20
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Chris Mattmann, Ph.D.
> Senior Computer Scientist
> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 171-266B, Mailstop: 171-246
> Email: chris.a.mattmann@nasa.gov
> WWW:   http://sunset.usc.edu/~mattmann/
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Adjunct Assistant Professor, Computer Science Department
> University of Southern California, Los Angeles, CA 90089 USA
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>=20