oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Wengine Task Querier Thread: OODT-310
Date Sun, 27 May 2012 21:58:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/
-----------------------------------------------------------

(Updated 2012-05-27 21:58:01.392196)


Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas
Bennett.


Changes
-------

Updated unit test, and changed the locking/synchronization logic. All unit tests pass and
I think this is good to go. I'll commit it tonight or tomorrow. Thanks all for the review!


Summary
-------

Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html


This addresses bug OODT-310.
    https://issues.apache.org/jira/browse/OODT-310


Diffs (updated)
-----

  ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ParallelProcessor.java
1342993 
  ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/SequentialProcessor.java
1342993 
  ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskProcessor.java 1342993

  ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1342993

  ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java
1342993 
  ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessorBuilder.java
PRE-CREATION 
  ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION


Diff: https://reviews.apache.org/r/4961/diff


Testing
-------

Includes unit test, that currently isn't passing. I think I know why (something up with my
threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely
be working on this tomorrow or the following evening.


Thanks,

Chris


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message