oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "brian Foster" <holen...@juno.com>
Subject Re: Review Request: Crawler command line bugs
Date Mon, 07 May 2012 20:50:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4989/#review7654
-----------------------------------------------------------



trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
<https://reviews.apache.org/r/4989/#comment16865>

    is your crawler synced?... this is what the trunk handleOption() method looks like right
now:
    
       @Override
       public void handleOption(CmdLineAction selectedAction,
             CmdLineOptionInstance optionInstance) {
          for (String beanProperty : properties) {
             if (optionInstance.getValues().size() > 1) {
                for (int i = 0; i < optionInstance.getValues().size(); i++) {
                   ActionBeanProperties.setProperty(beanProperty + "[" + i + "]",
                         optionInstance.getValues().get(i));
                }
             } else if (!optionInstance.getValues().isEmpty()) {
                ActionBeanProperties.setProperty(beanProperty,
                      optionInstance.getValues().get(0));
             } else {
                throw new RuntimeException(
                      CrawlerBeansPropHandler.class.getCanonicalName()
                            + " can't apply option '" + optionInstance.getOption()
                            + "' since it has no value");
             }
          }
       }



trunk/crawler/src/main/resources/cmd-line-options.xml
<https://reviews.apache.org/r/4989/#comment16867>

    good catch... think you've got a spelling error here though: Ulr should be Url



trunk/crawler/src/main/resources/cmd-line-options.xml
<https://reviews.apache.org/r/4989/#comment16866>

    good catch... i renamed this cause the original name didn't really make sense


- brian


On 2012-05-03 12:03:13, Thomas Bennett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4989/
> -----------------------------------------------------------
> 
> (Updated 2012-05-03 12:03:13)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
> 
> 
> Summary
> -------
> 
> 1) In handleOption(), test for multiple options and handle appropriately.
> 
> 2) Set the value for Unique.filemgrUlr in filemgrUrl bean.
> 
> 3) UpdateWorkflowStatusToIngest.workflowMgrUrl should be TriggerPostIngestWorkflow.workflowMgrUrl
> 
> 
> This addresses bug OODT-454.
>     https://issues.apache.org/jira/browse/OODT-454
> 
> 
> Diffs
> -----
> 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1332980 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
1305264 
> 
> Diff: https://reviews.apache.org/r/4989/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message