Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1BA9A97DD for ; Thu, 15 Mar 2012 18:06:52 +0000 (UTC) Received: (qmail 16019 invoked by uid 500); 15 Mar 2012 18:06:52 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 16003 invoked by uid 500); 15 Mar 2012 18:06:52 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Delivered-To: moderator for dev@oodt.apache.org Received: (qmail 17948 invoked by uid 99); 15 Mar 2012 08:25:39 -0000 Content-Type: multipart/alternative; boundary="===============0428954177515025033==" MIME-Version: 1.0 Subject: Re: Review Request: Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys From: "brian Foster" To: "Paul Ramirez" , "Thomas Bennett" , "Ricky Nguyen" , "Chris Mattmann" Date: Thu, 15 Mar 2012 08:25:38 -0000 Message-ID: <20120315082538.7140.43110@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4359/ Cc: "brian Foster" ,"oodt" In-Reply-To: <20120315080837.4803.29273@reviews.apache.org> References: <20120315080837.4803.29273@reviews.apache.org> --===============0428954177515025033== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4359/ ----------------------------------------------------------- (Updated 2012-03-15 08:25:38.715982) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Th= omas Bennett. Changes ------- Added unit-test to TestPGETaskInstance to verify Property Adders still load= correctly (as well as scalar values) with new isVector() support Summary ------- Will allow for specification of new keys while still supported legacy keys This addresses bug OODT-411. https://issues.apache.org/jira/browse/OODT-411 Diffs (updated) ----- trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300= 799 = trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBu= ilder.java 1300799 = trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PcsMetadataKeys.= java 1300798 = trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.j= ava 1300799 = trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 13007= 99 = trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.ja= va 1300799 = Diff: https://reviews.apache.org/r/4359/diff Testing ------- existing unit-tests for PgeTaskMetKeys Thanks, brian --===============0428954177515025033==--