Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@oodt.apache.org
Content-Type: multipart/alternative;
	boundary="===============4896338096404706114=="
MIME-Version: 1.0
Subject: Re: Review Request: Add CAS-PGE support for multiple Property Adders
From: "Chris Mattmann" <mattmann@apache.org>
To: "Paul Ramirez" <pramirez@jpl.nasa.gov>,
	"Chris Mattmann" <mattmann@apache.org>
Date: Tue, 13 Mar 2012 12:57:03 -0000
Message-ID: <20120313125703.15852.83853@reviews.apache.org>
Cc: "brian Foster" <holenote@juno.com>,"oodt" <dev@oodt.apache.org>
In-Reply-To: <20120313023718.15852.98459@reviews.apache.org>
References: <20120313023718.15852.98459@reviews.apache.org>

--===============4896338096404706114==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On 2012-03-13 02:37:18, Chris Mattmann wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, l=
ine 262
> > <https://reviews.apache.org/r/4303/diff/1/?file=3D91458#file91458line26=
2>
> >
> >     Interesting, is this extraneous or actually part of the patch?
> =

> brian Foster wrote:
>     i reformate the class... bad idea in hindsight... the only changes in=
 this class was the runPropertyAdders stuff and actionIds !=3D null check

Gotcha, I don't strongly object to the reformatting and if it's simple to j=
ust go forward with what you have, fine by me. I was just checking if it wa=
s something else that was being done.


> On 2012-03-13 02:37:18, Chris Mattmann wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, l=
ine 433
> > <https://reviews.apache.org/r/4303/diff/1/?file=3D91458#file91458line43=
3>
> >
> >     Interesting -- did this fix a bug in case actionIds was null?
> =

> brian Foster wrote:
>     ya but not here directly... PgeMetadata's getAllMetadata was returnin=
g empty list when it was supposed to return null when key didn't exist... r=
ealized this when adding the multi property adders which was a multi value =
key.

Cool, +1 to include it then. Seems minor enough, and related to the origina=
l intent of the patch.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4303/#review5867
-----------------------------------------------------------


On 2012-03-13 01:31:24, brian Foster wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4303/
> -----------------------------------------------------------
> =

> (Updated 2012-03-13 01:31:24)
> =

> =

> Review request for oodt, Chris Mattmann and Paul Ramirez.
> =

> =

> Summary
> -------
> =

> Will introduce the reserved metadata field: PGETask_PropertyAdders and de=
precate: PGETask_PropertyAdderClasspath
> =

> =

> This addresses bug OODT-406.
>     https://issues.apache.org/jira/browse/OODT-406
> =

> =

> Diffs
> -----
> =

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 12=
99921 =

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfig=
Builder.java 1299921 =

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.ja=
va 1299921 =

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadat=
aKeys.java 1298742 =

>   trunk/pge/src/test/org/apache/oodt/cas/pge/MockConfigFilePropertyAdder.=
java PRE-CREATION =

>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java PRE=
-CREATION =

> =

> Diff: https://reviews.apache.org/r/4303/diff
> =

> =

> Testing
> -------
> =

> Added unit-tests
> =

> =

> Thanks,
> =

> brian
> =

>


--===============4896338096404706114==--