Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@oodt.apache.org
Content-Type: multipart/alternative;
	boundary="===============6945687517263164225=="
MIME-Version: 1.0
Subject: Re: Review Request: Port wengine ControlMetadata to cas-pge's
 PgeMetadata
From: "brian Foster" <holenote@juno.com>
To: "Paul Ramirez" <pramirez@jpl.nasa.gov>,
	"Chris Mattmann" <mattmann@apache.org>
Date: Mon, 12 Mar 2012 20:42:31 -0000
Message-ID: <20120312204231.7141.95975@reviews.apache.org>
Cc: "brian Foster" <holenote@juno.com>,"oodt" <dev@oodt.apache.org>
In-Reply-To: <20120310174933.346.52416@reviews.apache.org>
References: <20120310174933.346.52416@reviews.apache.org>

--===============6945687517263164225==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On 2012-03-10 17:49:33, Chris Mattmann wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, l=
ine 453
> > <https://reviews.apache.org/r/4269/diff/2/?file=3D90993#file90993line45=
3>
> >
> >     Why not commit all keys -- or, maybe I am reading this wrong?

if you don't specify any args then all the marked keys will be committed, h=
owever you can provide a list of the mark keys which you would like to comm=
it if so desired.


> On 2012-03-10 17:49:33, Chris Mattmann wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.ja=
va, line 48
> > <https://reviews.apache.org/r/4269/diff/2/?file=3D90995#file90995line48>
> >
> >     Is this a change in the prior behavior?

currently if you point a link key to a dynamic key and then try to change t=
he link key's value, the dynamic metadata value remains unchanged and the l=
ink key is unlinked and readded as a key in the local metadata?... i can se=
e how this new behavior of it now actually changing the dynamic key's value=
 can be dangerous though if someone is not aware of it... i can change it b=
ack if you really think it is better to only have the one way which is mark=
ing the local or link key as dynamic then committing it.


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4269/#review5819
-----------------------------------------------------------


On 2012-03-10 01:32:07, brian Foster wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4269/
> -----------------------------------------------------------
> =

> (Updated 2012-03-10 01:32:07)
> =

> =

> Review request for oodt, Chris Mattmann and Paul Ramirez.
> =

> =

> Summary
> -------
> =

> Updates CAS-PGE's PgeMetadata to work similar to WEngine's ControlMetadata
> =

> =

> This addresses bug OODT-403.
>     https://issues.apache.org/jira/browse/OODT-403
> =

> =

> Diffs
> -----
> =

>   trunk/pge/pom.xml 1298742 =

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 12=
98742 =

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfig=
Builder.java 1298742 =

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.ja=
va 1298742 =

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/PcsMetFileWrite=
r.java 1298742 =

>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeMetadata.jav=
a PRE-CREATION =

> =

> Diff: https://reviews.apache.org/r/4269/diff
> =

> =

> Testing
> -------
> =

> added unit-test
> =

> =

> Thanks,
> =

> brian
> =

>


--===============6945687517263164225==--