oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Get product references before calling retrieveProduct(). Update unit tests testRetrieveFilesById() and testRetrieveFilesByName()
Date Fri, 30 Mar 2012 16:23:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4553/#review6580
-----------------------------------------------------------

Ship it!


LGTM!

- Chris


On 2012-03-30 08:45:40, Thomas Bennett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4553/
> -----------------------------------------------------------
> 
> (Updated 2012-03-30 08:45:40)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
> 
> 
> Summary
> -------
> 
> Get product references before calling retrieveProduct().
> 1) call setProductReferences method
> 2) remove d.retrieveProduct() outside the if else statement.
> 
> Fix unit tests testRetrieveFilesById() and testRetrieveFilesByName()
> 1) last method call is now getProductReferences not getProductByName/getProductById
> 2) The last method call has the product passed in as the argument. The call has been
modified to retrieve the productName/productId correctly from the method call.
> 
> 
> This addresses bug OODT-433.
>     https://issues.apache.org/jira/browse/OODT-433
> 
> 
> Diffs
> -----
> 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/RetrieveFilesCliAction.java
1306745 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java 1306745

> 
> Diff: https://reviews.apache.org/r/4553/diff
> 
> 
> Testing
> -------
> 
> * All unit tests now pass
> * filemgr deployed and tested with the filemgr client using both local and remote data
transfer factories.
> 
> 
> Thanks,
> 
> Thomas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message