oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "brian Foster" <holen...@juno.com>
Subject Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly
Date Mon, 26 Mar 2012 20:32:35 GMT


> On 2012-03-26 14:22:31, Chris Mattmann wrote:
> > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java,
line 60
> > <https://reviews.apache.org/r/4454/diff/1/?file=94689#file94689line60>
> >
> >     Agree with Tom here, do we need a check on if getValues() == null too?

i think what i'll do here is check if it is empty and then throw an Exception explicitly so
it is clear that a no arg option it wrong here... boolean options should have a static arg
specifying either true or false value.


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/#review6347
-----------------------------------------------------------


On 2012-03-22 21:27:55, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4454/
> -----------------------------------------------------------
> 
> (Updated 2012-03-22 21:27:55)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
> 
> 
> Summary
> -------
> 
> It currently was setting lists keys to: value1,value2,value3,...
> 
> This patch will instead change it to:
> key[0] = value1
> key[1] = value2
> 
> 
> This addresses bug OODT-428.
>     https://issues.apache.org/jira/browse/OODT-428
> 
> 
> Diffs
> -----
> 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
1304041 
> 
> Diff: https://reviews.apache.org/r/4454/diff
> 
> 
> Testing
> -------
> 
> still need a unit-test for this... will write when i get the time
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message