oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "brian Foster" <holen...@juno.com>
Subject Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)
Date Mon, 26 Mar 2012 20:29:23 GMT


> On 2012-03-26 15:50:17, Chris Mattmann wrote:
> > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java, line
326
> > <https://reviews.apache.org/r/4444/diff/2/?file=95394#file95394line326>
> >
> >     Are all of these @VisibleForTesting coupling our test system too much with the
code? Just wondering...

I just changing the visibility on these methods from private to package level... then i notated
them with the @VisibleForTesting to then make this clear to other developers that the only
reason for these methods being package level is to make them unit-test-able


> On 2012-03-26 15:50:17, Chris Mattmann wrote:
> > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java, line
71
> > <https://reviews.apache.org/r/4444/diff/2/?file=95395#file95395line71>
> >
> >     Should we augment the ProductCrawler super class to declare this function as
an abstract method since all sub class crawlers implement it?

it is... this method does need a @Override above it to make it clear... i'll add this


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4444/#review6349
-----------------------------------------------------------


On 2012-03-25 01:55:32, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4444/
> -----------------------------------------------------------
> 
> (Updated 2012-03-25 01:55:32)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
> 
> 
> Summary
> -------
> 
> - Introduced NamingConvention support, which for MetExtractorProductCrawler now takes
an ID for the NamingConvention to use and AutoDetectProductCrawler has a new element <namingConvention
class=""/> in MimeExtractorRepo
> - Also cleaned up handleFile(File)... documented better and is now public and returns
the IngestResult for what happened when called.
> 
> 
> This addresses bug OODT-426.
>     https://issues.apache.org/jira/browse/OODT-426
> 
> 
> Diffs
> -----
> 
>   trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION 
>   trunk/crawler/src/test/org/apache/oodt/cas/crawl/TestProductCrawler.java PRE-CREATION

>   trunk/crawler/src/main/resources/cmd-line-options.xml 1302790 
>   trunk/crawler/src/main/resources/crawler-config.xml 1302790 
>   trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java
1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 1302790

>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java
1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 1302790 
>   trunk/crawler/pom.xml 1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java
1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java
1302790 
> 
> Diff: https://reviews.apache.org/r/4444/diff
> 
> 
> Testing
> -------
> 
> Still need to unit-test up cas-crawler
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message