oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)
Date Mon, 26 Mar 2012 15:50:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4444/#review6349
-----------------------------------------------------------

Ship it!


My comments are pretty minor, but check em' out. LGTM.


trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java
<https://reviews.apache.org/r/4444/#comment13774>

    Are all of these @VisibleForTesting coupling our test system too much with the code? Just
wondering...



trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java
<https://reviews.apache.org/r/4444/#comment13775>

    Should we augment the ProductCrawler super class to declare this function as an abstract
method since all sub class crawlers implement it?


- Chris


On 2012-03-25 01:55:32, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4444/
> -----------------------------------------------------------
> 
> (Updated 2012-03-25 01:55:32)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
> 
> 
> Summary
> -------
> 
> - Introduced NamingConvention support, which for MetExtractorProductCrawler now takes
an ID for the NamingConvention to use and AutoDetectProductCrawler has a new element <namingConvention
class=""/> in MimeExtractorRepo
> - Also cleaned up handleFile(File)... documented better and is now public and returns
the IngestResult for what happened when called.
> 
> 
> This addresses bug OODT-426.
>     https://issues.apache.org/jira/browse/OODT-426
> 
> 
> Diffs
> -----
> 
>   trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION 
>   trunk/crawler/src/test/org/apache/oodt/cas/crawl/TestProductCrawler.java PRE-CREATION

>   trunk/crawler/src/main/resources/cmd-line-options.xml 1302790 
>   trunk/crawler/src/main/resources/crawler-config.xml 1302790 
>   trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java
1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 1302790

>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java
1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 1302790 
>   trunk/crawler/pom.xml 1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java
1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java
1302790 
> 
> Diff: https://reviews.apache.org/r/4444/diff
> 
> 
> Testing
> -------
> 
> Still need to unit-test up cas-crawler
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message