oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "brian Foster" <holen...@juno.com>
Subject Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values
Date Sat, 24 Mar 2012 19:22:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/#review6325
-----------------------------------------------------------

Ship it!


LGTM

- brian


On 2012-03-23 21:02:03, Ricky Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4451/
> -----------------------------------------------------------
> 
> (Updated 2012-03-23 21:02:03)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and
Thomas Bennett.
> 
> 
> Summary
> -------
> 
> Cleaned up metadata to string methods of QueryResult. If metadata was empty, it was trying
to delete a trailing comma that doesn't exist.
> 
> 
> This addresses bug OODT-427.
>     https://issues.apache.org/jira/browse/OODT-427
> 
> 
> Diffs
> -----
> 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java
1303205 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
1303205 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4451/diff
> 
> 
> Testing
> -------
> 
> Added unit test to check for empty metadata.
> 
> Changed existing unit test to account for implementation-dependent ordering of keys.
> 
> 
> Thanks,
> 
> Ricky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message