oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ricky Nguyen" <ricky.ngu...@gmail.com>
Subject Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values
Date Fri, 23 Mar 2012 21:19:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/
-----------------------------------------------------------

(Updated 2012-03-23 21:19:16.059506)


Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas
Bennett.


Changes
-------

test with multiple nulls. since order of null items is indeterminate, take sublist of null
items, then test size and test contains.


Summary
-------

putting nulls last


This addresses bug OODT-429.
    https://issues.apache.org/jira/browse/OODT-429


Diffs (updated)
-----

  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
1303205 
  trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/4458/diff


Testing
-------

wrote unit test


Thanks,

Ricky


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message