oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: CAS-PGE logger unit-test fails because it sometimes finds logger lock file
Date Tue, 20 Mar 2012 06:11:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4410/#review6111
-----------------------------------------------------------

Ship it!


LGTM.

- Chris


On 2012-03-20 01:41:27, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4410/
> -----------------------------------------------------------
> 
> (Updated 2012-03-20 01:41:27)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
> 
> 
> Summary
> -------
> 
> listFiles()[0] needs a filter, so that if logger lck files aren't deleted fast enough
the test doesn't parse the lck file instead of the log file
> 
> 
> This addresses bug OODT-425.
>     https://issues.apache.org/jira/browse/OODT-425
> 
> 
> Diffs
> -----
> 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1302703 
> 
> Diff: https://reviews.apache.org/r/4410/diff
> 
> 
> Testing
> -------
> 
> This patch is for a unit-test
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message