oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
Date Wed, 14 Mar 2012 19:28:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5960
-----------------------------------------------------------

Ship it!


LGTM!

- Chris


On 2012-03-14 05:18:33, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4326/
> -----------------------------------------------------------
> 
> (Updated 2012-03-14 05:18:33)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> The enum for met keys will allow for backwards compatibility to be toggled on/off easily
> 
> 
> This addresses bug OODT-409.
>     https://issues.apache.org/jira/browse/OODT-409
> 
> 
> Diffs
> -----
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
1300432 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java PRE-CREATION

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1300432

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java PRE-CREATION

>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/4326/diff
> 
> 
> Testing
> -------
> 
> Added/Updated Unit-Tests
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message