oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Add CAS-PGE support for multiple Property Adders
Date Tue, 13 Mar 2012 12:57:03 GMT


> On 2012-03-13 02:37:18, Chris Mattmann wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, line 262
> > <https://reviews.apache.org/r/4303/diff/1/?file=91458#file91458line262>
> >
> >     Interesting, is this extraneous or actually part of the patch?
> 
> brian Foster wrote:
>     i reformate the class... bad idea in hindsight... the only changes in this class
was the runPropertyAdders stuff and actionIds != null check

Gotcha, I don't strongly object to the reformatting and if it's simple to just go forward
with what you have, fine by me. I was just checking if it was something else that was being
done.


> On 2012-03-13 02:37:18, Chris Mattmann wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, line 433
> > <https://reviews.apache.org/r/4303/diff/1/?file=91458#file91458line433>
> >
> >     Interesting -- did this fix a bug in case actionIds was null?
> 
> brian Foster wrote:
>     ya but not here directly... PgeMetadata's getAllMetadata was returning empty list
when it was supposed to return null when key didn't exist... realized this when adding the
multi property adders which was a multi value key.

Cool, +1 to include it then. Seems minor enough, and related to the original intent of the
patch.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4303/#review5867
-----------------------------------------------------------


On 2012-03-13 01:31:24, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4303/
> -----------------------------------------------------------
> 
> (Updated 2012-03-13 01:31:24)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> Will introduce the reserved metadata field: PGETask_PropertyAdders and deprecate: PGETask_PropertyAdderClasspath
> 
> 
> This addresses bug OODT-406.
>     https://issues.apache.org/jira/browse/OODT-406
> 
> 
> Diffs
> -----
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1299921 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
1299921 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1299921 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1298742

>   trunk/pge/src/test/org/apache/oodt/cas/pge/MockConfigFilePropertyAdder.java PRE-CREATION

>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4303/diff
> 
> 
> Testing
> -------
> 
> Added unit-tests
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message