oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Add CAS-PGE support for multiple Property Adders
Date Tue, 13 Mar 2012 02:37:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4303/#review5867
-----------------------------------------------------------



trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4303/#comment12784>

    Great work!



trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4303/#comment12785>

    looks like just whitespace change, no biggie.



trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4303/#comment12786>

    Interesting, is this extraneous or actually part of the patch?



trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4303/#comment12787>

    Interesting -- did this fix a bug in case actionIds was null?



trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
<https://reviews.apache.org/r/4303/#comment12788>

    extraneous?



trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
<https://reviews.apache.org/r/4303/#comment12789>

    Nice, way to indicate this.


- Chris


On 2012-03-13 01:31:24, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4303/
> -----------------------------------------------------------
> 
> (Updated 2012-03-13 01:31:24)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> Will introduce the reserved metadata field: PGETask_PropertyAdders and deprecate: PGETask_PropertyAdderClasspath
> 
> 
> This addresses bug OODT-406.
>     https://issues.apache.org/jira/browse/OODT-406
> 
> 
> Diffs
> -----
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1299921 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
1299921 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1299921 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1298742

>   trunk/pge/src/test/org/apache/oodt/cas/pge/MockConfigFilePropertyAdder.java PRE-CREATION

>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4303/diff
> 
> 
> Testing
> -------
> 
> Added unit-tests
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message