oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "brian Foster" <holen...@juno.com>
Subject Re: Review Request: Port wengine ControlMetadata to cas-pge's PgeMetadata
Date Mon, 12 Mar 2012 20:42:31 GMT


> On 2012-03-10 17:49:33, Chris Mattmann wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, line 453
> > <https://reviews.apache.org/r/4269/diff/2/?file=90993#file90993line453>
> >
> >     Why not commit all keys -- or, maybe I am reading this wrong?

if you don't specify any args then all the marked keys will be committed, however you can
provide a list of the mark keys which you would like to commit if so desired.


> On 2012-03-10 17:49:33, Chris Mattmann wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java, line
48
> > <https://reviews.apache.org/r/4269/diff/2/?file=90995#file90995line48>
> >
> >     Is this a change in the prior behavior?

currently if you point a link key to a dynamic key and then try to change the link key's value,
the dynamic metadata value remains unchanged and the link key is unlinked and readded as a
key in the local metadata?... i can see how this new behavior of it now actually changing
the dynamic key's value can be dangerous though if someone is not aware of it... i can change
it back if you really think it is better to only have the one way which is marking the local
or link key as dynamic then committing it.


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4269/#review5819
-----------------------------------------------------------


On 2012-03-10 01:32:07, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4269/
> -----------------------------------------------------------
> 
> (Updated 2012-03-10 01:32:07)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> Updates CAS-PGE's PgeMetadata to work similar to WEngine's ControlMetadata
> 
> 
> This addresses bug OODT-403.
>     https://issues.apache.org/jira/browse/OODT-403
> 
> 
> Diffs
> -----
> 
>   trunk/pge/pom.xml 1298742 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1298742 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
1298742 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1298742 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/PcsMetFileWriter.java 1298742

>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeMetadata.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/4269/diff
> 
> 
> Testing
> -------
> 
> added unit-test
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message