oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: OODT-361: Workflow test event fails with NPE
Date Wed, 29 Feb 2012 06:07:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4089/#review5438
-----------------------------------------------------------

Ship it!


Minor comment, all looks well.

- Chris


On 2012-02-28 20:05:18, Ricky Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4089/
> -----------------------------------------------------------
> 
> (Updated 2012-02-28 20:05:18)
> 
> 
> Review request for oodt.
> 
> 
> Summary
> -------
> 
> When DateConvert.isoParse is given a null input, it throws NPE.
> Solution is throw ParseException if input is null. WorkflowInstance catches ParseException
and ignores it.
> 
> 
> This addresses bug OODT-361.
>     https://issues.apache.org/jira/browse/OODT-361
> 
> 
> Diffs
> -----
> 
>   trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 1294802 
> 
> Diff: https://reviews.apache.org/r/4089/diff
> 
> 
> Testing
> -------
> 
> Ran HelloWorld, GoodbyeWorld.
> 
> 
> Thanks,
> 
> Ricky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message