Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07F617F6C for ; Tue, 29 Nov 2011 21:11:12 +0000 (UTC) Received: (qmail 80064 invoked by uid 500); 29 Nov 2011 21:11:11 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 80045 invoked by uid 500); 29 Nov 2011 21:11:11 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Received: (qmail 80037 invoked by uid 99); 29 Nov 2011 21:11:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Nov 2011 21:11:11 +0000 X-ASF-Spam-Status: No, hits=-0.1 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of paul.m.ramirez@jpl.nasa.gov designates 128.149.139.109 as permitted sender) Received: from [128.149.139.109] (HELO mail.jpl.nasa.gov) (128.149.139.109) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Nov 2011 21:11:02 +0000 Received: from mail.jpl.nasa.gov (altvirehtstap02.jpl.nasa.gov [128.149.137.73]) by smtp.jpl.nasa.gov (Switch-3.4.3/Switch-3.4.3) with ESMTP id pATL0r8W018220 (using TLSv1/SSLv3 with cipher RC4-MD5 (128 bits) verified NO); Tue, 29 Nov 2011 13:10:09 -0800 Received: from ALTPHYEMBEVSP20.RES.AD.JPL ([128.149.137.83]) by ALTVIREHTSTAP02.RES.AD.JPL ([128.149.137.73]) with mapi; Tue, 29 Nov 2011 13:09:55 -0800 From: "Ramirez, Paul M (388J)" To: brian Foster CC: "Ramirez, Paul M (388J)" , Chris Mattmann , oodt Date: Tue, 29 Nov 2011 13:09:53 -0800 Subject: Re: Review Request: Integrate CAS-CLI into CAS-Filemgr Thread-Topic: Review Request: Integrate CAS-CLI into CAS-Filemgr Thread-Index: Acyu2z3dPZIM/3ocT/KswncMyDIHyw== Message-ID: <0506975B-2E13-4E7C-A272-1ECF7222D126@jpl.nasa.gov> References: <20111128164939.13131.61944@reviews.apache.org> <20111128173817.13131.32589@reviews.apache.org> In-Reply-To: <20111128173817.13131.32589@reviews.apache.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: multipart/alternative; boundary="_000_0506975B2E134E7CA2721ECF7222D126jplnasagov_" MIME-Version: 1.0 X-Source-IP: altvirehtstap02.jpl.nasa.gov [128.149.137.73] X-Source-Sender: paul.m.ramirez@jpl.nasa.gov X-AUTH: Authorized --_000_0506975B2E134E7CA2721ECF7222D126jplnasagov_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey Brian, That sounds like the perfect balance to make the psa and op align better. Thanks, Paul On Nov 28, 2011, at 9:38 AM, brian Foster wrote: This is an automatically generated e-mail. To reply, visit: https://reviews= .apache.org/r/2946/ On November 28th, 2011, 4:49 p.m., Paul Ramirez wrote: Looks good. The only comment I have is there seems to be a mismatch in the = -psa and the action names that get listed and the operations that can be tr= iggered. Seems like there may need to be a mapping there. When you look up = help on an action you use the ActionName. When you do an operation its by i= ts flag. Although there is seemingly a one to one mapping the command line = arguments don't seem interchangeable. when you use -h it tells you which command line flags to use... we= can change the name of the actions to start lowercased like the flag if yo= u think that will get rid of some confusion - brian On November 28th, 2011, 8:43 a.m., brian Foster wrote: Review request for oodt, Chris Mattmann and Paul Ramirez. By brian Foster. Updated 2011-11-28 08:43:27 Description Issue being tracked at: https://issues.apache.org/jira/browse/OODT-351 Added command-line options for filemgr: $ ./filemgr-client -h ---------------------------------------------------------------------------= -------------------------------------- | Short | Long | Description ---------------------------------------------------------------------------= -------------------------------------- -op, --operation Declare that yo= u wish to present an operation SubOptions: > Required: > Optional: -addPT, --addProductType Triggers AddPro= ductType Action Requirement R= ules: [AddProductT= ype : REQUIRED] -dbyid, --deleteProductById Triggers Delete= ProductById Action Requirement R= ules: [DeleteProdu= ctById : REQUIRED] -dbyn, --deleteProductByName Triggers Delete= ProductByName Action Requirement R= ules: [DeleteProdu= ctByName : REQUIRED] -ingest,--ingestProduct Triggers Ingest= Product Action Requirement R= ules: [IngestProdu= ct : REQUIRED] -product,--hasProduct Triggers HasPr= oduct Action Requirement R= ules: [HasProduct = : REQUIRED] -ptbyn, --getProductTypeByName Triggers GetPro= ductTypeByName Action Requirement R= ules: [GetProductT= ypeByName : REQUIRED] -num, --getNumProducts Triggers GetNum= Products Action Requirement R= ules: [GetNumProdu= cts : REQUIRED] -page1, --getFirstPage Triggers GetFir= stPage Action Requirement R= ules: [GetFirstPag= e : REQUIRED] -next, --getNextPage Triggers GetNex= tPage Action Requirement R= ules: [GetNextPage= : REQUIRED] -prev, --getPrevPage Triggers GetPre= vPage Action Requirement R= ules: [GetPrevPage= : REQUIRED] -last, --getLastPage Triggers GetLas= tPage Action Requirement R= ules: [GetLastPage= : REQUIRED] -curTran,--getCurrentTransfer Triggers GetCu= rrentTransfer Action Requirement R= ules: [GetCurrentT= ransfer : REQUIRED] -curTrans,--getCurrentTransfers Triggers GetC= urrentTransfers Action Requirement R= ules: [GetCurrentT= ransfers : REQUIRED] -pbyid, --getProductById Triggers GetPro= ductById Action Requirement R= ules: [GetProductB= yId : REQUIRED] -pbyn, --getProductByName Triggers GetPro= ductByName Action Requirement R= ules: [GetProductB= yName : REQUIRED] -pctTrans,--getProductPctTransferred Triggers GetP= roductPercentTransferred Action Requirement R= ules: [GetProductP= ercentTransferred : REQUIRED] -filePctTrans,--getFilePctTransferred Triggers = GetFilePercentTransferred Action Requirement R= ules: [GetFilePerc= entTransferred : REQUIRED] -sql, --sqlQuery Triggers SqlQue= ry Action Requirement R= ules: [SqlQuery : = REQUIRED] -u, --url Workflow Manage= r URL Handler: Sets the fol= lowing Java Properties: [org.apache.= oodt.cas.workflow.url] -f, --filter Query filter Requirement R= ules: [SqlQuery : = OPTIONAL] SubOptions: > Required: -algor, --algor FilterAlgor cla= ss Requirement R= ules: [SqlQuery : = REQUIRED] Handler: Will invoke = 'setAlgor' on action selected, except for the foll= owing actions: [] -sdtMetKey,--startDateTimeMetKey Start date t= ime metadata key Requirement R= ules: [SqlQuery : = REQUIRED] Handler: Will invoke = 'setStartDateTimeMetKey' on action selected, ex= cept for the following actions: [] -edtMetKey,--endDateTimeMetKey End date tim= e metadata key Requirement R= ules: [SqlQuery : = REQUIRED] Handler: Will invoke = 'setEndDateTimeMetKey' on action selected, ex= cept for the following actions: [] -prMetKey,--priorityMetKey Priority meta= data key Requirement R= ules: [SqlQuery : = REQUIRED] Handler: Will invoke = 'setPriorityMetKey' on action selected, ex= cept for the following actions: [] > Optional: -conv, --converter VersionConverte= r class Requirement R= ules: [SqlQuery : = OPTIONAL] Handler: Will invoke = 'setConverter' on action selected, except for t= he following actions: [] -pn, --productName Product name Requirement R= ules: [IngestProdu= ct : REQUIRED, HasProduct : REQUIRED, GetProductBy= Name : REQUIRED, DeleteProductByName : REQUIRED] Handler: Will invoke = 'setProductName' on action selected, except for t= he following actions: [] -vc, --versionClass ProductType ver= sioner class Requirement R= ules: [AddProductT= ype : REQUIRED] Handler: Will invoke = 'setVersionClass' on action selected, except for t= he following actions: [AddProductType : setVersion= er] -mf, --metadataFile Metadata XML fi= le path or URL Requirement R= ules: [IngestProdu= ct : REQUIRED] Handler: Will invoke = 'setMetadataFile' on action selected, except for t= he following actions: [] -curPage,--currentPageNum Current Page N= umber Requirement R= ules: [GetNextPage= : REQUIRED, GetPrevPage : REQUIRED] Handler: Will invoke = 'setCurrentPageNum' on action selected, ex= cept for the following actions: [] -ps, --productStructure Hierarchical | = Flat Requirement R= ules: [IngestProdu= ct : REQUIRED] Handler: Will invoke = 'setProductStructure' on action selected, ex= cept for the following actions: [IngestProdu= ct : setProductStructure] -ptn, --productTypeName ProductType nam= e Requirement R= ules: [IngestProdu= ct : REQUIRED, GetProductTypeByName : REQUIRED, Ge= tNumProducts : REQUIRED, GetFirstPage : REQUIRED, = GetNextPage : REQUIRED, GetPrevPage : REQUIRED, Ge= tLastPage : REQUIRED, GetProductPe= rcentTransferred : REQUIRED] Handler: Will invoke = 'setProductTypeName' on action selected, ex= cept for the following actions: [] -rs, --refs Data file path = or URL Requirement R= ules: [IngestProdu= ct : REQUIRED] Handler: Will invoke = 'setRefs' on action selected, except for the foll= owing actions: [IngestProduct : setReference= s] -repo, --repository ProductType rep= ository Requirement R= ules: [AddProductT= ype : REQUIRED] Handler: Will invoke = 'setRepository' on action selected, except for t= he following actions: [AddProductType : setFileRep= ositoryPath] -sb, --sortBy Metadata field = to sort query results by Requirement R= ules: [SqlQuery : = OPTIONAL] Handler: Will invoke = 'setSortBy' on action selected, except for the foll= owing actions: [] -tn, --typeName ProductType nam= e Requirement R= ules: [AddProductT= ype : REQUIRED] Handler: Will invoke = 'setTypeName' on action selected, except for t= he following actions: [AddProductType : setProduct= TypeName] -dlmtr, --delimiter String to use t= he separate query results Requirement R= ules: [SqlQuery : = OPTIONAL] Handler: Will invoke = 'setDelimiter' on action selected, except for t= he following actions: [] -pid, --productId Product ID Requirement R= ules: [GetProductP= ercentTransferred : REQUIRED, GetProductBy= Id : REQUIRED, DeleteProductById : REQUIRED] Handler: Will invoke = 'setProductId' on action selected, except for t= he following actions: [] -td, --typeDesc ProductType des= cription Requirement R= ules: [AddProductT= ype : REQUIRED] Handler: Will invoke = 'setTypeDesc' on action selected, except for t= he following actions: [AddProductType : setProduct= TypeDescription] -or, --origRef Original refere= nce Requirement R= ules: [GetFilePerc= entTransferred : REQUIRED] Handler: Will invoke = 'setOrigRef' on action selected, except for t= he following actions: [] -ct, --clientTransfer User client tra= nsferer Requirement R= ules: [IngestProdu= ct : OPTIONAL] SubOptions: > Required: -dt, --dataTransfer DataTransferer = factory class Requirement R= ules: [IngestProdu= ct : REQUIRED] Handler: Will invoke = 'setDataTransfer' on action selected, except for t= he following actions: [IngestProduct : setDataTrans= ferer] > Optional: -q, --query File Manager qu= ery Requirement R= ules: [SqlQuery : = REQUIRED] Handler: Will invoke = 'setQuery' on action selected, except for the foll= owing actions: [] -of, --outputFormat Output format s= tring (i.e. Filename =3D $Filename) Requirement R= ules: [SqlQuery : = OPTIONAL] Handler: Will invoke = 'setOutputFormat' on action selected, except for t= he following actions: [] -h, --help Prints help men= u -psa, --printSupportedActions Print Supported= Actions ---------------------------------------------------------------------------= -------------------------------------- $ ./filemgr-client -psa Actions: Action: Name: GetPrevPage Description: Gets prev page of Products of given ProductType Action: Name: DeleteProductByName Description: Delete Product by name Action: Name: GetFilePercentTransferred Description: Gets the percent amount transferred of given file Action: Name: GetProductById Description: Gets Product info by ID Action: Name: HasProduct Description: Checks if Product with given name has been ingested Action: Name: GetProductTypeByName Description: Gets a ProductType by its name Action: Name: GetCurrentTransfers Description: Gets the status of the current Product file transfers Action: Name: SqlQuery Description: Queries by parsing an SQL-like query into a FileManager Qu= ery Action: Name: GetProductPercentTransferred Description: Gets percent amount transferred of a Products data files Action: Name: DeleteProductById Description: Delete Product by ID Action: Name: GetNumProducts Description: Gets number of Products ingested for a given ProductType Action: Name: IngestProduct Description: Ingests a Product Action: Name: GetNextPage Description: Gets next page of Products of given ProductType Action: Name: AddProductType Description: Adds a ProductType to list of supported ProductTypes Action: Name: GetFirstPage Description: Gets first page of Products of given ProductType Action: Name: GetProductByName Description: Get Product info by name Action: Name: GetLastPage Description: Gets last page of Products of given ProductType Action: Name: GetCurrentTransfer Description: Gets the status of the current Product file transfer $ ./filemgr-client -h IngestProduct Action Help for 'IngestProduct' - Required: -u [--url] -op [--operation] -ingest [--ingestProduct] (required) -pn [--productName] -mf [--metadataFile] -ptn [--productTypeName] -ps [--productStructure] -rs [--refs] - Optional: -ct [--clientTransfer] -dt [--dataTransfer] (required) Testing many unit-tests Diffs * trunk/filemgr/pom.xml (1203939) * trunk/filemgr/src/main/assembly/assembly.xml (1203939) * trunk/filemgr/src/main/bin/filemgr-client (1203939) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Abs= tractDeleteProductCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Abs= tractGetProductCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Add= ProductTypeCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Del= eteProductByIdCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Del= eteProductByNameCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Fil= eManagerCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= CurrentTransferCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= CurrentTransfersCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= FilePercentTransferredCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= FirstPageCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= LastPageCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= NextPageCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= NumProductsCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= PrevPageCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= ProductByIdCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= ProductByNameCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= ProductPercentTransferredCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Get= ProductTypeByNameCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Has= ProductCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Ing= estProductCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/Sql= QueryCliAction.java (PRE-CREATION) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcF= ileManagerClient.java (1203939) * trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/DeletePr= oduct.java (1203939) * trunk/filemgr/src/main/resources/cmd-line-actions.xml (PRE-CREATION) * trunk/filemgr/src/main/resources/cmd-line-options.xml (PRE-CREATION) * trunk/filemgr/src/main/resources/logging.properties (1203939) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManager= Cli.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/UseMockClientCm= dLineActionStore.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestAddP= roductTypeCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestDele= teProductByIdCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestDele= teProductByNameCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetC= urrentTransferCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetC= urrentTransfersCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetF= ilePercentTransferredCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetF= irstPageCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetL= astPageCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetN= extPageCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetN= umProductsCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetP= revPageCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetP= roductByIdCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetP= roductByNameCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetP= roductPercentTransferredCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetP= roductTypeByNameCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestHasP= roductCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestInge= stProductCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQ= ueryCliAction.java (PRE-CREATION) * trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/MockXmlRpcFi= leManagerClient.java (PRE-CREATION) View Diff --_000_0506975B2E134E7CA2721ECF7222D126jplnasagov_--