oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
Date Mon, 21 Nov 2011 00:09:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2884/#review3382
-----------------------------------------------------------

Ship it!


Looks great, +1 from me!

- Chris


On 2011-11-21 00:08:18, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2884/
> -----------------------------------------------------------
> 
> (Updated 2011-11-21 00:08:18)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> issue is tracked here: https://issues.apache.org/jira/browse/OODT-353
> 
> 
> Diffs
> -----
> 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/XmlRpcStructFactory.java
1203939 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/MockCatalog.java PRE-CREATION

>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/MockCatalogFactory.java
PRE-CREATION 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/util/TestXmlRpcStructFactory.java
1203939 
> 
> Diff: https://reviews.apache.org/r/2884/diff
> 
> 
> Testing
> -------
> 
> unit-tests included in patch
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message