oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "brian Foster" <holen...@juno.com>
Subject Re: Review Request: getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
Date Mon, 21 Nov 2011 00:04:35 GMT


> On 2011-11-20 23:46:10, Chris Mattmann wrote:
> > trunk/filemgr/src/testdata/xmlrpc-struct-factory/product-types.xml, line 21
> > <https://reviews.apache.org/r/2884/diff/3/?file=59504#file59504line21>
> >
> >     I think it would still work fine since repo path is env var replaced with $HOME.

i switched it back and ya it works... weird, it was blowing up on me yesterday until i made
the change... oh well, works now!


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2884/#review3380
-----------------------------------------------------------


On 2011-11-20 23:41:35, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2884/
> -----------------------------------------------------------
> 
> (Updated 2011-11-20 23:41:35)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> issue is tracked here: https://issues.apache.org/jira/browse/OODT-353
> 
> 
> Diffs
> -----
> 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/XmlRpcStructFactory.java
1203939 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/MockCatalog.java PRE-CREATION

>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/MockCatalogFactory.java
PRE-CREATION 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/util/TestXmlRpcStructFactory.java
1203939 
>   trunk/filemgr/src/testdata/xmlrpc-struct-factory/product-types.xml 1203939 
> 
> Diff: https://reviews.apache.org/r/2884/diff
> 
> 
> Testing
> -------
> 
> unit-tests included in patch
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message