oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object
Date Sun, 20 Nov 2011 21:26:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2884/#review3376
-----------------------------------------------------------



trunk/filemgr/src/testdata/xmlrpc-struct-factory/product-types.xml
<https://reviews.apache.org/r/2884/#comment7555>

    I am +1 for all of the above, but not for  this one. I think we have the best chance of
being able to write to [HOME]/files on systems where an OODT dev/user is running the unit
tests. We've seen other OODT issues https://issues.apache.org/jira/browse/OODT-318 and https://issues.apache.org/jira/browse/OODT-110
and other dev discussion crop up when trying to write to /tmp, so can we leave it as [HOME]/files?
If you want to distinguish it from the default shipped policy, we could always do [HOME]/testfiles,
but that would seem to be an orthogonal change to this patch.


- Chris


On 2011-11-20 20:32:25, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2884/
> -----------------------------------------------------------
> 
> (Updated 2011-11-20 20:32:25)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> issue is tracked here: https://issues.apache.org/jira/browse/OODT-353
> 
> 
> Diffs
> -----
> 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/XmlRpcStructFactory.java
1203939 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/MockCatalog.java PRE-CREATION

>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/MockCatalogFactory.java
PRE-CREATION 
>   trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/util/TestXmlRpcStructFactory.java
1203939 
>   trunk/filemgr/src/testdata/xmlrpc-struct-factory/product-types.xml 1203939 
> 
> Diff: https://reviews.apache.org/r/2884/diff
> 
> 
> Testing
> -------
> 
> unit-tests included in patch
> 
> 
> Thanks,
> 
> brian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message