oodt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Laidlaw (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OODT-452) Move the default File Manager policy files to 'core' subdirectory
Date Sat, 19 May 2012 18:36:40 GMT

    [ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279596#comment-13279596
] 

Ross Laidlaw edited comment on OODT-452 at 5/19/12 6:36 PM:
------------------------------------------------------------

When building OODT, the following code in assembly.xml (in _filemgr/src/main/assembly_) copies
the contents of the _filemgr/src/main/resources/examples_ directory to the _filemgr/policy_
directory in the build target:

{code}
<fileSet>
  <directory>${basedir}/src/main/resources/examples</directory>
  <outputDirectory>policy</outputDirectory>
  <includes/>
</fileSet>
{code}

It also copies subdirectories and their contents too.  This means that the newly created _core_
and _geo_ subdirectories will be copied over along with any files they contain.  I've checked
the [documentation for the maven assembly plugin|http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html]
and this is by design rather than by accident:

_"When <include> subelements are present, they define a set of project coordinates to
include. If none is present, then <includes> represents all valid values..."_

I've tested this by building the latest OODT trunk and confirming that the _core_ and _geo_
directories and contents were copied over to the target policy directory, as expected.  

This means that in the future we could add more example configurations as subdirectories and
these would automatically be picked up.

Therefore, to complete this task, all that's required is for a committer to perform svn moves
for the three core files and commit the changes.  As far as I can see, no further actions
would be required (i.e. no modifications to any other files), because when I made these changes
locally none of the tests for the build were affected.

As a newly appointed OODT committer I'd be happy to move and commit the files if the OODT
team are happy for me to go ahead.

Following the changes, to access the core files the filemgr.properties file can be updated
reference the _policy/core_ subdirectory rather than the _policy_ directory, for example as
follows:

{code}
org.apache.oodt.cas.filemgr.repositorymgr.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
org.apache.oodt.cas.filemgr.validation.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
{code}

                
      was (Author: rlaidlaw):
    When building OODT, the following code in assembly.xml (in _filemgr/src/main/assembly_)
copies the contents of the _filemgr/src/main/resources/examples_ directory to the _filemgr/policy_
directory in the build target:

{code}
<fileSet>
  <directory>${basedir}/src/main/resources/examples</directory>
  <outputDirectory>policy</outputDirectory>
  <includes/>
</fileSet>
{code}

It also copies subdirectories and their contents too.  This means that the newly created _core_
and _geo_ subdirectories will be copied over along with any files they contain.  I've checked
the [documentation for the maven assembly plugin|http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html]
and this is by design rather than by accident:

_"When <include> subelements are present, they define a set of project coordinates to
include. If none is present, then <includes> represents all valid values..."_

I've tested this by building the latest OODT trunk and confirming that the _core_ and _geo_
directories and contents were copied over to the target policy directory, as expected.  

This means that in the future we could add more example configurations as subdirectories and
these would automatically be picked up.

Therefore, to complete this task, all that's required is for a committer to perform svn moves
for the three core files and commit the changes.  As far as I can see, no further actions
would be required (i.e. no modifications to any other files), because I have made these changes
locally and none of the tests for the build were affected.

As a newly appointed OODT committer I'd be happy to move and commit the files if the OODT
team are happy for me to go ahead.

Following the changes, to access the core files the filemgr.properties file can be updated
reference the _policy/core_ subdirectory rather than the _policy_ directory, for example as
follows:

{code}
org.apache.oodt.cas.filemgr.repositorymgr.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
org.apache.oodt.cas.filemgr.validation.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
{code}

                  
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
>                 Key: OODT-452
>                 URL: https://issues.apache.org/jira/browse/OODT-452
>             Project: OODT
>          Issue Type: Sub-task
>          Components: file manager
>            Reporter: Ross Laidlaw
>              Labels: gsoc2012
>             Fix For: 0.5
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples,
i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml'
to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message