oodt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OODT-454) Crawler command line bugs
Date Mon, 07 May 2012 20:50:52 GMT

    [ https://issues.apache.org/jira/browse/OODT-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269988#comment-13269988
] 

jiraposter@reviews.apache.org commented on OODT-454:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4989/#review7654
-----------------------------------------------------------



trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
<https://reviews.apache.org/r/4989/#comment16865>

    is your crawler synced?... this is what the trunk handleOption() method looks like right
now:
    
       @Override
       public void handleOption(CmdLineAction selectedAction,
             CmdLineOptionInstance optionInstance) {
          for (String beanProperty : properties) {
             if (optionInstance.getValues().size() > 1) {
                for (int i = 0; i < optionInstance.getValues().size(); i++) {
                   ActionBeanProperties.setProperty(beanProperty + "[" + i + "]",
                         optionInstance.getValues().get(i));
                }
             } else if (!optionInstance.getValues().isEmpty()) {
                ActionBeanProperties.setProperty(beanProperty,
                      optionInstance.getValues().get(0));
             } else {
                throw new RuntimeException(
                      CrawlerBeansPropHandler.class.getCanonicalName()
                            + " can't apply option '" + optionInstance.getOption()
                            + "' since it has no value");
             }
          }
       }



trunk/crawler/src/main/resources/cmd-line-options.xml
<https://reviews.apache.org/r/4989/#comment16867>

    good catch... think you've got a spelling error here though: Ulr should be Url



trunk/crawler/src/main/resources/cmd-line-options.xml
<https://reviews.apache.org/r/4989/#comment16866>

    good catch... i renamed this cause the original name didn't really make sense


- brian


On 2012-05-03 12:03:13, Thomas Bennett wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4989/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-05-03 12:03:13)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  1) In handleOption(), test for multiple options and handle appropriately.
bq.  
bq.  2) Set the value for Unique.filemgrUlr in filemgrUrl bean.
bq.  
bq.  3) UpdateWorkflowStatusToIngest.workflowMgrUrl should be TriggerPostIngestWorkflow.workflowMgrUrl
bq.  
bq.  
bq.  This addresses bug OODT-454.
bq.      https://issues.apache.org/jira/browse/OODT-454
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/crawler/src/main/resources/cmd-line-options.xml 1332980 
bq.    trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
1305264 
bq.  
bq.  Diff: https://reviews.apache.org/r/4989/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Thomas
bq.  
bq.


                
> Crawler command line bugs
> -------------------------
>
>                 Key: OODT-454
>                 URL: https://issues.apache.org/jira/browse/OODT-454
>             Project: OODT
>          Issue Type: Bug
>          Components: crawler
>    Affects Versions: 0.4
>            Reporter: Thomas Bennett
>            Assignee: Thomas Bennett
>            Priority: Minor
>              Labels: patch
>             Fix For: 0.4
>
>
> I've think I've flushed out a few crawler command line bugs:
> 1) --actionIds can currently fails when more than 1 actionId is specified
> 2) ActionId Unique fails because the filemgrUrl is not set.
> 3) ActionId TriggerPostIngestWorkflow is not configured correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message