oodt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OODT-310) Port WEngine to trunk
Date Wed, 02 May 2012 21:32:51 GMT

    [ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266928#comment-13266928
] 

jiraposter@reviews.apache.org commented on OODT-310:
----------------------------------------------------



bq.  On 2012-05-02 19:20:13, brian Foster wrote:
bq.  > ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java,
line 89
bq.  > <https://reviews.apache.org/r/4961/diff/1/?file=105930#file105930line89>
bq.  >
bq.  >     Why do you want Holding category to be returned?

good question I messed that up. Should be !(processor.getState().getCategory().getName().equals("done")
|| processor.getState().getCategory().getName().equals("holding")) IOW not either of those.


Fixed in latest version. Will upload soon.


bq.  On 2012-05-02 19:20:13, brian Foster wrote:
bq.  > ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java,
line 130
bq.  > <https://reviews.apache.org/r/4961/diff/1/?file=105930#file105930line130>
bq.  >
bq.  >     This should return a copy of runnableProcessors here... probably where your
synchronization issue is

PERFECT idea! Thanks dude.


bq.  On 2012-05-02 19:20:13, brian Foster wrote:
bq.  > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java,
line 60
bq.  > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line60>
bq.  >
bq.  >     getRunnableProcessors() is never null... probably should be a unit-test to insure
that functionality

Agreed. Will add.


bq.  On 2012-05-02 19:20:13, brian Foster wrote:
bq.  > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java,
line 61
bq.  > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line61>
bq.  >
bq.  >     !querier.getRunnableProcessors().isEmpty()

yep better idea.


bq.  On 2012-05-02 19:20:13, brian Foster wrote:
bq.  > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java,
line 79
bq.  > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79>
bq.  >
bq.  >     When Success/done is passed in, the processor created is incorrect since it
has a sub-processor in Queued/waiting

Thoughts on how to fix?


bq.  On 2012-05-02 19:20:13, brian Foster wrote:
bq.  > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java,
line 125
bq.  > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line125>
bq.  >
bq.  >     Should probably add a NOT done processor here

Yep good idea. Will add.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/#review7482
-----------------------------------------------------------


On 2012-05-02 05:08:45, Chris Mattmann wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4961/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-05-02 05:08:45)
bq.  
bq.  
bq.  Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas
Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
bq.  
bq.  
bq.  This addresses bug OODT-310.
bq.      https://issues.apache.org/jira/browse/OODT-310
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java
1332505 
bq.    ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java
1331866 
bq.    ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4961/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Includes unit test, that currently isn't passing. I think I know why (something up with
my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely
be working on this tomorrow or the following evening.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Chris
bq.  
bq.


                
> Port WEngine to trunk
> ---------------------
>
>                 Key: OODT-310
>                 URL: https://issues.apache.org/jira/browse/OODT-310
>             Project: OODT
>          Issue Type: Sub-task
>          Components: workflow manager
>            Reporter: Chris A. Mattmann
>            Assignee: Chris A. Mattmann
>             Fix For: 0.5
>
>         Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt,
OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and
associated classes to trunk. This involves changing to the Processor model (Sequential, Condition,
etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself,
that doesn't block and that includes a queue-based model developed by [~bfoster].

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message