oodt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris A. Mattmann (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OODT-336) xmlps should omit joining of tables that are unnecessary to fulfill query
Date Tue, 18 Oct 2011 01:20:10 GMT

    [ https://issues.apache.org/jira/browse/OODT-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129396#comment-13129396
] 

Chris A. Mattmann commented on OODT-336:
----------------------------------------

Thanks Ricky.

Looking at the patch, it seems like there is a few different issues conflated in a single
patch, specifically these 3:

{quote}
* fixed some methods in XMLPSProductHandler that should return empty lists instead of null
(unit test was throwing NPE's)
* MappingReader adds default join table to DatabaseTable if none defined (simplifies SQL query
building and join table lookups)
* changed unit test constructor to setUp() method (better repeatability between tests, especially
since I am changing the handler)
{quote}

Seem like they could be 3 separate issues. I would favor that approach, since as I mentioned
before, smallish, easily revertable, incremental 
patches are preferred.
                
> xmlps should omit joining of tables that are unnecessary to fulfill query
> -------------------------------------------------------------------------
>
>                 Key: OODT-336
>                 URL: https://issues.apache.org/jira/browse/OODT-336
>             Project: OODT
>          Issue Type: Improvement
>          Components: xmlps
>    Affects Versions: 0.4
>            Reporter: Ricky Nguyen
>            Assignee: Chris A. Mattmann
>             Fix For: 0.4
>
>         Attachments: rickdn-oodt-336.patch
>
>
> Suppose we have tables A, B and C.  If we are only querying and returning fields from
A and B, then the inclusion of table C in the SQL join statement will produce repeated entries
of matching rows.  It would be beneficial if XMLPS could intelligently select the required
join tables from the fields in the query.
> In CHLA's specific case, table C causes millions of repeated rows (and subsequently OutOfMemory
java heap space error).
> I have a proposed fix that I can upload shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message