oodt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris A. Mattmann (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OODT-195) XMLValidationLayer: Elements Map and ProductType to Element Map can become inconsistent
Date Sun, 29 May 2011 06:10:47 GMT

    [ https://issues.apache.org/jira/browse/OODT-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040752#comment-13040752
] 

Chris A. Mattmann commented on OODT-195:
----------------------------------------

bq. probably many of the methods in this class should be synchronized as well

This was one of the things I struggled with initially -- how much addition/removal functionality
to put into this class, which I really intended to be more of a "reader" -- versus having
an explicit curation version of this class that handles the add/edit/remove. 

I agree that the add/edit/remove functions should likely be synchronized. I just wonder if
they should be moved to a separate version of the class used for curation since they aren't
really used anywhere in existing file manager code (which just uses the read version of the
functions). 



> XMLValidationLayer: Elements Map and ProductType to Element Map can become inconsistent
> ---------------------------------------------------------------------------------------
>
>                 Key: OODT-195
>                 URL: https://issues.apache.org/jira/browse/OODT-195
>             Project: OODT
>          Issue Type: Bug
>          Components: file manager
>            Reporter: Michael Starch
>            Priority: Minor
>
> XMLValidation layer does not update the the product-type-to-element map upon element
modification or removal.  Thus the product-type-to-element map can contain elements that have
been removed, or modified, leaving it inconsistent with the elements contained in the element
map.
> As suggested by Brian Foster:
> The product-type-to-element map can be changed to map ProductType to ElemementId strings.
 Then the actual element can be obtained from the element map.  The product-type-to-element
map would still need to be updated (see below solution) on removal of an element to ensure
that it contains no elements previously removed.
> An alternative solution:
> Update both maps upon modification or removal.  This way allows both modified elements
and removed elements are handled in the exact same manner. This fix will fail if the element
map is modified outside of the removeElement or modifyElement methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message