Return-Path: Delivered-To: apmail-oodt-commits-archive@www.apache.org Received: (qmail 41263 invoked from network); 7 Dec 2010 08:06:30 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 7 Dec 2010 08:06:30 -0000 Received: (qmail 72805 invoked by uid 500); 7 Dec 2010 08:06:30 -0000 Delivered-To: apmail-oodt-commits-archive@oodt.apache.org Received: (qmail 72769 invoked by uid 500); 7 Dec 2010 08:06:30 -0000 Mailing-List: contact commits-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list commits@oodt.apache.org Received: (qmail 72758 invoked by uid 99); 7 Dec 2010 08:06:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Dec 2010 08:06:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Dec 2010 08:06:29 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oB7868Dh016606 for ; Tue, 7 Dec 2010 08:06:09 GMT Message-ID: <19025910.19111291709168801.JavaMail.jira@thor> Date: Tue, 7 Dec 2010 03:06:08 -0500 (EST) From: "Brian Foster (JIRA)" To: commits@oodt.apache.org Subject: [jira] Commented: (OODT-68) Add Number of Product Hits to ProductPage In-Reply-To: <12394652.11471291680728837.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OODT-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968622#action_12968622 ] Brian Foster commented on OODT-68: ---------------------------------- - the patch would be backwards compatible . . . setTotalPages(int) should only be used by Catalog implementations and each Catalog was doing its own number of page calculations (i.e. has to be reimplemented for each Catalog implemented) -- setTotalPages(int) is the only method which would be dropped . . . a setter method for number of hits would take its place. - also with all this new gui development around the filemgr . . . paging is a heavily used feature . . . having to double query just to get the first page and the number of hits i think should be addressed -- it greatly affects page load time over large data sets > Add Number of Product Hits to ProductPage > ----------------------------------------- > > Key: OODT-68 > URL: https://issues.apache.org/jira/browse/OODT-68 > Project: OODT > Issue Type: Improvement > Components: file manager > Affects Versions: 0.1-incubating > Environment: none > Reporter: Brian Foster > Assignee: Brian Foster > Priority: Minor > Fix For: 0.2 > > > - By adding get number of hits the method setTotalPages(int) is no longer needed; getTotalPages will calculate its return value based on page size and total hits > - This also allows the number of products to be determined by just getting the first page, instead of getting last page which internally requires DataSourceCatalog to get first page and last page -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.