omid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OMID-117) Ensure timeouts are configured low for RPCs to commit table
Date Mon, 15 Oct 2018 01:22:00 GMT

    [ https://issues.apache.org/jira/browse/OMID-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649618#comment-16649618
] 

James Taylor commented on OMID-117:
-----------------------------------

The InterRegionServerRpcController is only a few lines of code and you'd need the constructor
in both classes, so I don't think it's worth it.

I've attached a v7 that passes for hbase-1 and hbase-2. For the tests to pass, I had to have
the server-side retry. Without this, we'd get a NoServerForRegionException which is a DoNotRetryIOException
so doesn't trigger any retries on the client. I'm not sure if this is a test-only issue. I
added a long comment, but I don't have the cycles to explore further. For hbase-2 I could
only test it by changing the poms to make hbase-2 the default profile (see attached). I'll
let that be figured out for OMID-109.

Is this ok to commit, [~yonigo]?

 

> Ensure timeouts are configured low for RPCs to commit table
> -----------------------------------------------------------
>
>                 Key: OMID-117
>                 URL: https://issues.apache.org/jira/browse/OMID-117
>             Project: Apache Omid
>          Issue Type: Bug
>            Reporter: James Taylor
>            Priority: Major
>         Attachments: OMID-117.patch, OMID-117_v2.patch, OMID-117_v3.patch, OMID-117_v4.patch,
OMID-117_v5.patch, OMID-117_v6.patch, OMID-117_v7.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message