omid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yonigottesman <...@git.apache.org>
Subject [GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...
Date Sun, 29 Jul 2018 06:15:41 GMT
Github user yonigottesman commented on a diff in the pull request:

    https://github.com/apache/incubator-omid/pull/39#discussion_r205961640
  
    --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java
---
    @@ -98,20 +98,13 @@ void setCommitTableClient(CommitTable.Client commitTableClient) {
          * @param commitCache         Holds shadow cells information
          * @return Whether the cell was deleted
          */
    -    private boolean checkFamilyDeletionCache(Cell cell, HBaseTransaction transaction,
Map<String, List<Cell>> familyDeletionCache, Map<Long, Long> commitCache)
throws IOException {
    -        List<Cell> familyDeletionCells = familyDeletionCache.get(Bytes.toString((cell.getRow())));
    -        if (familyDeletionCells != null) {
    -            for(Cell familyDeletionCell : familyDeletionCells) {
    -                String family = Bytes.toString(cell.getFamily());
    -                String familyDeletion = Bytes.toString(familyDeletionCell.getFamily());
    -                if (family.equals(familyDeletion)) {
    -                    Optional<Long> familyDeletionCommitTimestamp = getCommitTimestamp(familyDeletionCell,
transaction, commitCache);
    -                    if (familyDeletionCommitTimestamp.isPresent() && familyDeletionCommitTimestamp.get()
>= cell.getTimestamp()) {
    -                        return true;
    -                    }
    -                }
    -            }
    +    private boolean checkFamilyDeletionCache(Cell cell, HBaseTransaction transaction,
Map<String, Long> familyDeletionCache, Map<Long, Long> commitCache) throws IOException
{
    +        String key = Bytes.toString((cell.getRow())) + ":" + Bytes.toString(cell.getFamily());
    --- End diff --
    
    export this + ":" + to a function
    getRowFamilyString(Cell) and also use it later.


---

Mime
View raw message