oltu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Sanso (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (OLTU-200) Wrong regex in TokenReader
Date Tue, 02 Aug 2016 11:01:20 GMT

     [ https://issues.apache.org/jira/browse/OLTU-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Antonio Sanso resolved OLTU-200.
--------------------------------
       Resolution: Fixed
    Fix Version/s: commons-encodedtokens-1.0.1

fixed in r1754866

> Wrong regex in TokenReader
> --------------------------
>
>                 Key: OLTU-200
>                 URL: https://issues.apache.org/jira/browse/OLTU-200
>             Project: Apache Oltu
>          Issue Type: Bug
>          Components: oauth2-common
>            Reporter: Antonio Sanso
>            Assignee: Simone Tripodi
>             Fix For: commons-encodedtokens-1.0.1
>
>
> The regex in TokenReader [0] doesn't comply with the JWS spec.
> The spec [1] says:
> {code}
> BASE64URL(UTF8(JWS Protected Header)) || '.' ||
>      BASE64URL(JWS Payload) || '.' ||
>      BASE64URL(JWS Signature)
> {code}
> while the impl regex is 
> {code}
> private final Pattern base64urlTokenPattern = Pattern.compile("([a-zA-Z0-9/+=]+)\\.([a-zA-Z0-9/+=]+)\\.(.+)");
> {code}
> it should be rather
> {code}
> private final  base64urlTokenPattern = Pattern.compile("([a-zA-Z0-9-​_=]+)\\.([a-zA-Z0-9-_​=]+)\\.([a-zA-Z0-9-_=]+)
> {code}
> [0] https://github.com/apache/oltu/blob/trunk/commons/encodedtoken/src/main/java/org/apache/oltu/commons/encodedtoken/TokenReader.java#L30
> [1] https://tools.ietf.org/html/rfc7515



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message