Mailing-List: contact dev-help@oltu.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@oltu.apache.org
Received-SPF: pass (nike.apache.org: domain of asanso@adobe.com designates
 65.55.169.86 as permitted sender)
From: Antonio Sanso <asanso@adobe.com>
To: "dev@oltu.apache.org" <dev@oltu.apache.org>
Subject: Re: JSON comparison in test case best practice
Thread-Topic: JSON comparison in test case best practice
Thread-Index: AQHQELshCsNoEAtsX0WX/mr4TDC3hpyBVW2AgAACLoCAAAFjgIAAL8KAgAGGtwA=
Date: Sat, 6 Dec 2014 21:01:50 +0000
Message-ID: <C27F7C2C-74C8-4349-A139-37CEF509A16E@adobe.com>
References: 
 <CAAqLGLMwuKMHgt9gH0rueK=3i1HNxQC2MDKpBsbs-gxF0GontA@mail.gmail.com>
 <CAAqLGLMg2cfWwoxufezBn+qxORyd7TFzfuB263dFyKcWxtAD6g@mail.gmail.com>
 <CAAqLGLNO1P8H7-V4Nqv6is2xcaFMF0u+eFDPbmBPxzrP7=kvrg@mail.gmail.com>
 <CAAqLGLO0tPUSn3ht74ex9p6tEVeG057LTSVA_0yA1SFMwUr=fA@mail.gmail.com>
 <CAAqLGLP=isJYpfv2Qy_CVzyOSpwBeqgc81458gED_KDCNhVDbg@mail.gmail.com>
In-Reply-To: 
 <CAAqLGLP=isJYpfv2Qy_CVzyOSpwBeqgc81458gED_KDCNhVDbg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A6024B3663AF5144BFF1864D2FF37009@namprd02.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

hi Simo, see comment in the issue

regards

antonio
On Dec 5, 2014, at 10:47 PM, Simone Tripodi <simonetripodi@apache.org> wrot=
e:

> patch attached! :P
>=20
> http://people.apache.org/~simonetripodi/
> http://twitter.com/simonetripodi
>=20
> On Fri, Dec 5, 2014 at 11:56 AM, Simone Tripodi <simonetripodi@apache.org=
>
> wrote:
>=20
>> last message, promised: I followed up on OLTU-164
>>=20
>> best,
>> -Simo
>>=20
>> http://people.apache.org/~simonetripodi/
>> http://twitter.com/simonetripodi
>>=20
>> On Fri, Dec 5, 2014 at 11:51 AM, Simone Tripodi <simonetripodi@apache.or=
g>
>> wrote:
>>=20
>>> just for the record: yes, I noticed it, WWWAuthHeaderParametersApplierT=
est
>>> does not handle JSON at all :P
>>> please apologise! :D
>>> -Simo
>>>=20
>>> http://people.apache.org/~simonetripodi/
>>> http://twitter.com/simonetripodi
>>>=20
>>> On Fri, Dec 5, 2014 at 11:44 AM, Simone Tripodi <simonetripodi@apache.o=
rg
>>>> wrote:
>>>=20
>>>> Looks like there's a nice tool called JSONAssert that does the legwork=
 -
>>>> and I am not surprised someone already thought on doing that :)
>>>> I am fixing broken tests to make them working but will let the
>>>> discussion open in order to find a general agreement... please join!
>>>> All the best,
>>>> -Simo
>>>>=20
>>>> [1] http://jsonassert.skyscreamer.org/
>>>>=20
>>>> http://people.apache.org/~simonetripodi/
>>>> http://twitter.com/simonetripodi
>>>>=20
>>>> On Fri, Dec 5, 2014 at 11:39 AM, Simone Tripodi <
>>>> simonetripodi@apache.org> wrote:
>>>>=20
>>>>> Hi all mates,
>>>>>=20
>>>>> there are a couple of tests in the oauth-2.0/common codebase failing =
on
>>>>> CLI, but succeed in Eclipse, see below for details...
>>>>>=20
>>>>> I honestly think that comparing serialised JSON strings is not thebes=
t
>>>>> way to assert two JSON documents are representing exactly the same da=
ta, we
>>>>> need to handle that situation...
>>>>>=20
>>>>> Does anybody know a best practice to compare json object, such as
>>>>> XMLDiff of something else?
>>>>> I am asking google, in the meanwhile... :)
>>>>> Best,
>>>>> -Simo
>>>>>=20
>>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~=
~
>>>>>=20
>>>>> OAuthResponseTest.testErrorResponse:47 expected:<{"[error_uri":"
>>>>> http://example-uri","error":"error","param":"value","realm":"album","=
state":"ok","error_description":"error_description]"}>
>>>>> but
>>>>> was:<{"[param":"value","error_description":"error_description","realm=
":"album","state":"ok","error":"error","error_uri":"
>>>>> http://example-uri]"}>
>>>>>=20
>>>>>  WWWAuthHeaderParametersApplierTest.testApplyOAuthParameters:60
>>>>> expected:<...ope=3D"s1 s2 s3",error[_uri=3D"http://www.example.com/er=
ror",error=3D"invalid_token]">
>>>>> but was:<...ope=3D"s1 s2 s3",error[=3D"invalid_token",error_uri=3D"
>>>>> http://www.example.com/error]">
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://twitter.com/simonetripodi
>>>>>=20
>>>>=20
>>>>=20
>>>=20
>>=20