oltu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OLTU-164) JSON comparison in test case best practice
Date Sat, 06 Dec 2014 21:10:12 GMT

    [ https://issues.apache.org/jira/browse/OLTU-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236975#comment-14236975
] 

Simone Tripodi commented on OLTU-164:
-------------------------------------

SO, something is broken, because I am no longer able to install {{/trunk}} anymore on my laptop
with the following environment:

{noromat}
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed
in 8.0
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 06:51:28-0700)
Maven home: /Applications/apache-maven-3.0.5
Java version: 1.8.0_25, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_25.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.10.1", arch: "x86_64", family: "mac"
{noformat}

Details are reported on the issue description... any idea?

> JSON comparison in test case best practice
> ------------------------------------------
>
>                 Key: OLTU-164
>                 URL: https://issues.apache.org/jira/browse/OLTU-164
>             Project: Apache Oltu
>          Issue Type: Test
>            Reporter: Simone Tripodi
>            Priority: Critical
>         Attachments: OLTU-164.patch
>
>
> there are a couple of tests in the oauth-2.0/common codebase failing on CLI, but succeed
in Eclipse, see below for details...
> {noformat}
> OAuthResponseTest.testErrorResponse:47 expected:<{"[error_uri":"http://example-uri","error":"error","param":"value","realm":"album","state":"ok","error_description":"error_description]"}>
but was:<{"[param":"value","error_description":"error_description","realm":"album","state":"ok","error":"error","error_uri":"http://example-uri]"}>
> {noformat}
> I honestly think that comparing serialised JSON strings is not the best way to assert
two JSON documents are representing exactly the same data, we need to handle that situation...
> The [jsonassert|http://jsonassert.skyscreamer.org/] library looks like to be the good
choice to assert two json object represent exactly the same data.
> If there are no objections, I would use {{jsonassert}} in all tests handling JSON data
representation...
> Thoughts? TIA! :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message