Return-Path: X-Original-To: apmail-oltu-dev-archive@www.apache.org Delivered-To: apmail-oltu-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1DA40116AF for ; Fri, 11 Apr 2014 11:51:55 +0000 (UTC) Received: (qmail 10903 invoked by uid 500); 11 Apr 2014 11:51:54 -0000 Delivered-To: apmail-oltu-dev-archive@oltu.apache.org Received: (qmail 10818 invoked by uid 500); 11 Apr 2014 11:51:47 -0000 Mailing-List: contact dev-help@oltu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oltu.apache.org Delivered-To: mailing list dev@oltu.apache.org Received: (qmail 10581 invoked by uid 99); 11 Apr 2014 11:51:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Apr 2014 11:51:44 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of simone.tripodi@gmail.com designates 209.85.219.49 as permitted sender) Received: from [209.85.219.49] (HELO mail-oa0-f49.google.com) (209.85.219.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Apr 2014 11:51:38 +0000 Received: by mail-oa0-f49.google.com with SMTP id o6so5960379oag.22 for ; Fri, 11 Apr 2014 04:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=qWmwuRVZlmKg9H53WqijM3PstyaKAFiPzdxDcEF7MNc=; b=kbOF6/XDi80Dtvsc/51OPhogp+596KQHWProQKsv54wLhTQLve2wPqby22LW/dI8HX cXsNlTjTPc7q5fh9xjDuYNuFa4+DTswSTAHwetw9l0gHzW8YSvCOJRS+W6B0ju0U9utA TTfg19OBn7bxC2zvZy+jymSWVLdBCB0Ejuw1AHJRx2dEm0bmBVd6rNeXODyrJUiClZ3y i4aMxxMwihTpzJMlbRV7CqzhcNI5fNthf1XboB42qW9Oc3BtIP0nxWwg34jx0xqF1DiH RdSIun5oSjftpYcmVO4DO/QmAPZL+eXtfGp5CqAZKDk9CDvSR8yWCtNcq3b3yUJP33S7 Mqrg== MIME-Version: 1.0 X-Received: by 10.182.33.6 with SMTP id n6mr18879955obi.48.1397217076005; Fri, 11 Apr 2014 04:51:16 -0700 (PDT) Sender: simone.tripodi@gmail.com Received: by 10.60.42.69 with HTTP; Fri, 11 Apr 2014 04:51:15 -0700 (PDT) In-Reply-To: <20140401105629.949492388999@eris.apache.org> References: <20140401105629.949492388999@eris.apache.org> Date: Fri, 11 Apr 2014 13:51:15 +0200 X-Google-Sender-Auth: IHDeo7wNQkzr6oThzNAe11DiOSY Message-ID: Subject: Re: svn commit: r1583609 - in /oltu/trunk/jose/jws: ./ src/main/java/org/apache/oltu/jose/jws/ src/main/java/org/apache/oltu/jose/jws/signature/impl/ From: Simone Tripodi To: dev@oltu.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org Hi Tonino, just few considerations: > +public class JwsConstants { > + > + public static final String RS256 = "RS256"; > + > + public static final String RS384 = "RS384"; > + > + public static final String RS512 = "RS512"; > +} I'd reduce this class constructor as 'private' > > Added: oltu/trunk/jose/jws/src/main/java/org/apache/oltu/jose/jws/signature/impl/PrivateKey.java I wouldn't add that classes to a generic 'impl' package, they refer to specific 'java.security' implementation, so I would suggest to: * having them implemented in a separated module/bundle * package name be renamed WDYT? Best, -Simo