Mailing-List: contact dev-help@oltu.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@oltu.apache.org
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
From: =?utf-8?Q?=C5=81ukasz_Dywicki?= <luke@code-house.org>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_D11E010F-BE7B-4B66-AE67-78BC3968BA26"
Message-Id: <5949B9B9-D117-41DF-AD41-71F6FB231E19@code-house.org>
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
Subject: Re: svn commit: r1583609 - in /oltu/trunk/jose/jws: ./
 src/main/java/org/apache/oltu/jose/jws/
 src/main/java/org/apache/oltu/jose/jws/signature/impl/
Date: Sat, 12 Apr 2014 12:29:54 +0200
References: <20140401105629.949492388999@eris.apache.org>
 <CAAqLGLO0mhySNfzY8n9ri1+5dHa80JUc=rkc5fxSydViAx2utw@mail.gmail.com>
 <390C2D23-D265-4490-8D90-14F299D46DEA@adobe.com>
To: dev@oltu.apache.org
In-Reply-To: <390C2D23-D265-4490-8D90-14F299D46DEA@adobe.com>

--Apple-Mail=_D11E010F-BE7B-4B66-AE67-78BC3968BA26
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

If thiss class contains just constants you can make it as interface and =
skip repeated "public static final=E2=80=9D and also avoid checkstyle =
crying about constructor. :)

Cheers,
=C5=81ukasz Dywicki
--
luke@code-house.org
Twitter: ldywicki
Blog: http://dywicki.pl
Code-House - http://code-house.org

Wiadomo=C5=9B=C4=87 napisana przez Antonio Sanso <asanso@adobe.com> w =
dniu 11 kwi 2014, o godz. 14:45:

> hi Simo +1
>=20
> Maybe we can leave in the same bundle though. Just not in the impl =
package=E2=80=A6
>=20
> regards
>=20
> antonio
>=20
> On Apr 11, 2014, at 1:51 PM, Simone Tripodi <simonetripodi@apache.org> =
wrote:
>=20
>> Hi Tonino,
>>=20
>> just few considerations:
>>=20
>>> +public class JwsConstants {
>>> +
>>> +    public static final String RS256 =3D "RS256";
>>> +
>>> +    public static final String RS384 =3D "RS384";
>>> +
>>> +    public static final String RS512 =3D "RS512";
>>> +}
>>=20
>> I'd reduce this class constructor as 'private'
>>=20
>>>=20
>>> Added: =
oltu/trunk/jose/jws/src/main/java/org/apache/oltu/jose/jws/signature/impl/=
PrivateKey.java
>>=20
>> I wouldn't add that classes to a generic 'impl' package, they refer =
to
>> specific 'java.security' implementation, so I would suggest to:
>>=20
>> * having them implemented in a separated module/bundle
>>=20
>> * package name be renamed
>>=20
>> WDYT?
>> Best,
>> -Simo
>=20


--Apple-Mail=_D11E010F-BE7B-4B66-AE67-78BC3968BA26--