oltu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simonetrip...@apache.org>
Subject Re: svn commit: r1583609 - in /oltu/trunk/jose/jws: ./ src/main/java/org/apache/oltu/jose/jws/ src/main/java/org/apache/oltu/jose/jws/signature/impl/
Date Fri, 11 Apr 2014 11:51:15 GMT
Hi Tonino,

just few considerations:

> +public class JwsConstants {
> +
> +    public static final String RS256 = "RS256";
> +
> +    public static final String RS384 = "RS384";
> +
> +    public static final String RS512 = "RS512";
> +}

I'd reduce this class constructor as 'private'

>
> Added: oltu/trunk/jose/jws/src/main/java/org/apache/oltu/jose/jws/signature/impl/PrivateKey.java

I wouldn't add that classes to a generic 'impl' package, they refer to
specific 'java.security' implementation, so I would suggest to:

 * having them implemented in a separated module/bundle

 * package name be renamed

WDYT?
Best,
-Simo

Mime
View raw message