oltu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antonio Sanso <asa...@adobe.com>
Subject Re: svn commit: r1583609 - in /oltu/trunk/jose/jws: ./ src/main/java/org/apache/oltu/jose/jws/ src/main/java/org/apache/oltu/jose/jws/signature/impl/
Date Fri, 11 Apr 2014 12:45:13 GMT
hi Simo +1

Maybe we can leave in the same bundle though. Just not in the impl packageā€¦

regards

antonio

On Apr 11, 2014, at 1:51 PM, Simone Tripodi <simonetripodi@apache.org> wrote:

> Hi Tonino,
> 
> just few considerations:
> 
>> +public class JwsConstants {
>> +
>> +    public static final String RS256 = "RS256";
>> +
>> +    public static final String RS384 = "RS384";
>> +
>> +    public static final String RS512 = "RS512";
>> +}
> 
> I'd reduce this class constructor as 'private'
> 
>> 
>> Added: oltu/trunk/jose/jws/src/main/java/org/apache/oltu/jose/jws/signature/impl/PrivateKey.java
> 
> I wouldn't add that classes to a generic 'impl' package, they refer to
> specific 'java.security' implementation, so I would suggest to:
> 
> * having them implemented in a separated module/bundle
> 
> * package name be renamed
> 
> WDYT?
> Best,
> -Simo


Mime
View raw message