Return-Path: X-Original-To: apmail-incubator-amber-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-amber-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 82D6596FF for ; Tue, 14 Feb 2012 11:58:04 +0000 (UTC) Received: (qmail 31547 invoked by uid 500); 14 Feb 2012 11:53:41 -0000 Delivered-To: apmail-incubator-amber-dev-archive@incubator.apache.org Received: (qmail 20776 invoked by uid 500); 14 Feb 2012 11:52:04 -0000 Mailing-List: contact amber-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: amber-dev@incubator.apache.org Delivered-To: mailing list amber-dev@incubator.apache.org Received: (qmail 6084 invoked by uid 99); 14 Feb 2012 10:12:08 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2012 10:12:08 +0000 X-ASF-Spam-Status: No, hits=0.9 required=5.0 tests=FRT_ADOBE2,HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of asanso@adobe.com designates 64.18.1.27 as permitted sender) Received: from [64.18.1.27] (HELO exprod6og111.obsmtp.com) (64.18.1.27) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2012 10:11:58 +0000 Received: from outbound-smtp-2.corp.adobe.com ([193.104.215.16]) by exprod6ob111.postini.com ([64.18.5.12]) with SMTP ID DSNKTzozWJGxHbUTMqZjB2fYWI0sDOyuzlGz@postini.com; Tue, 14 Feb 2012 02:11:37 PST Received: from inner-relay-4.eur.adobe.com (inner-relay-4b [10.128.4.237]) by outbound-smtp-2.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q1EABa2d011749 for ; Tue, 14 Feb 2012 02:11:36 -0800 (PST) Received: from nacas01.corp.adobe.com (nacas01.corp.adobe.com [10.8.189.99]) by inner-relay-4.eur.adobe.com (8.12.10/8.12.9) with ESMTP id q1EABYPl003364 for ; Tue, 14 Feb 2012 02:11:35 -0800 (PST) Received: from eurcas01.eur.adobe.com (10.128.4.27) by nacas01.corp.adobe.com (10.8.189.99) with Microsoft SMTP Server (TLS) id 8.3.192.1; Tue, 14 Feb 2012 02:11:34 -0800 Received: from eurmbx01.eur.adobe.com ([10.128.4.32]) by eurcas01.eur.adobe.com ([10.128.4.27]) with mapi; Tue, 14 Feb 2012 10:11:31 +0000 From: Antonio Sanso To: "amber-dev@incubator.apache.org" Date: Tue, 14 Feb 2012 10:11:29 +0000 Subject: Fwd: svn commit: r1243684 - in /incubator/amber/trunk/oauth-2.0: oauth2-authzserver/src/test/java/org/apache/amber/oauth2/as/response/ oauth2-common/src/main/java/org/apache/amber/oauth2/common/ oauth2-common/src/main/java/org/apache/amber/oauth2/commo... Thread-Topic: svn commit: r1243684 - in /incubator/amber/trunk/oauth-2.0: oauth2-authzserver/src/test/java/org/apache/amber/oauth2/as/response/ oauth2-common/src/main/java/org/apache/amber/oauth2/common/ oauth2-common/src/main/java/org/apache/amber/oauth2/commo... Thread-Index: AczrAQV8b1ZF3M8yS3K+z4z3gEMJxA== Message-ID: References: <635267B1-B7F5-4B6A-A4EA-7EB8A5C4E10E@adobe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: multipart/alternative; boundary="_000_B087781AD6504F92AF4F0D467C9946D3adobecom_" MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org --_000_B087781AD6504F92AF4F0D467C9946D3adobecom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Begin forwarded message: From: Antonio Sanso > Date: February 14, 2012 10:01:21 AM GMT+01:00 To: "amber-dev@incubator.apache.org"= > Subject: Re: svn commit: r1243684 - in /incubator/amber/trunk/oauth-2.0: oa= uth2-authzserver/src/test/java/org/apache/amber/oauth2/as/response/ oauth2-= common/src/main/java/org/apache/amber/oauth2/common/ oauth2-common/src/main= /java/org/apache/amber/oauth2/common... Hi Lukasz, thanks a lot for tackling this. Just a minor one. I am not really sure about this: On Feb 13, 2012, at 9:46 PM, > = > wrote: - public static final String OAUTH_TOKEN =3D "oauth_token"; + public static final String OAUTH_TOKEN =3D "access_token"; Reason is this is used (containing the old value of oauth_token) in the pat= ch you have committed for AMBER-28 [0] with the follow strategy: " It will check the presence of "access_token" first and fall back to "oaut= h_token"" as for Raymond comment. WDYT? Regards Antonio [0] https://issues.apache.org/jira/browse/AMBER-28 --_000_B087781AD6504F92AF4F0D467C9946D3adobecom_--