Return-Path: X-Original-To: apmail-incubator-amber-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-amber-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F20369F70 for ; Tue, 14 Feb 2012 11:56:25 +0000 (UTC) Received: (qmail 27766 invoked by uid 500); 14 Feb 2012 11:53:16 -0000 Delivered-To: apmail-incubator-amber-dev-archive@incubator.apache.org Received: (qmail 25781 invoked by uid 500); 14 Feb 2012 11:52:53 -0000 Mailing-List: contact amber-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: amber-dev@incubator.apache.org Delivered-To: mailing list amber-dev@incubator.apache.org Received: (qmail 4183 invoked by uid 99); 14 Feb 2012 09:01:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2012 09:01:57 +0000 X-ASF-Spam-Status: No, hits=-0.1 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of asanso@adobe.com designates 64.18.1.23 as permitted sender) Received: from [64.18.1.23] (HELO exprod6og109.obsmtp.com) (64.18.1.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2012 09:01:48 +0000 Received: from outbound-smtp-2.corp.adobe.com ([193.104.215.16]) by exprod6ob109.postini.com ([64.18.5.12]) with SMTP ID DSNKTzoi5xbjRGsdR9wngbbfiLtwTSDSvakt@postini.com; Tue, 14 Feb 2012 01:01:27 PST Received: from inner-relay-1.corp.adobe.com (inner-relay-1.sea.adobe.com [153.32.1.51]) by outbound-smtp-2.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q1E91P2d005664 for ; Tue, 14 Feb 2012 01:01:25 -0800 (PST) Received: from nacas01.corp.adobe.com (nacas01.corp.adobe.com [10.8.189.99]) by inner-relay-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q1E91OMM006143 for ; Tue, 14 Feb 2012 01:01:24 -0800 (PST) Received: from eurcas01.eur.adobe.com (10.128.4.27) by nacas01.corp.adobe.com (10.8.189.99) with Microsoft SMTP Server (TLS) id 8.3.192.1; Tue, 14 Feb 2012 01:01:24 -0800 Received: from eurmbx01.eur.adobe.com ([10.128.4.32]) by eurcas01.eur.adobe.com ([10.128.4.27]) with mapi; Tue, 14 Feb 2012 09:01:23 +0000 From: Antonio Sanso To: "amber-dev@incubator.apache.org" Date: Tue, 14 Feb 2012 09:01:21 +0000 Subject: Re: svn commit: r1243684 - in /incubator/amber/trunk/oauth-2.0: oauth2-authzserver/src/test/java/org/apache/amber/oauth2/as/response/ oauth2-common/src/main/java/org/apache/amber/oauth2/common/ oauth2-common/src/main/java/org/apache/amber/oauth2/common... Thread-Topic: svn commit: r1243684 - in /incubator/amber/trunk/oauth-2.0: oauth2-authzserver/src/test/java/org/apache/amber/oauth2/as/response/ oauth2-common/src/main/java/org/apache/amber/oauth2/common/ oauth2-common/src/main/java/org/apache/amber/oauth2/common... Thread-Index: Aczq9zl5i7xwlw3bSEywRRAay5dmeg== Message-ID: <635267B1-B7F5-4B6A-A4EA-7EB8A5C4E10E@adobe.com> References: <20120213204652.8E58623888D2@eris.apache.org> In-Reply-To: <20120213204652.8E58623888D2@eris.apache.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: multipart/alternative; boundary="_000_635267B1B7F54B6AA4EA7EB8A5C4E10Eadobecom_" MIME-Version: 1.0 --_000_635267B1B7F54B6AA4EA7EB8A5C4E10Eadobecom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Lukasz, thanks a lot for tackling this. Just a minor one. I am not really sure about this: On Feb 13, 2012, at 9:46 PM, > = > wrote: - public static final String OAUTH_TOKEN =3D "oauth_token"; + public static final String OAUTH_TOKEN =3D "access_token"; Reason is this is used (containing the old value of oauth_token) in the pat= ch you have committed for AMBER-28 [0] with the follow strategy: " It will check the presence of "access_token" first and fall back to "oaut= h_token"" as for Raymond comment. WDYT? Regards Antonio [0] https://issues.apache.org/jira/browse/AMBER-28 --_000_635267B1B7F54B6AA4EA7EB8A5C4E10Eadobecom_--