oltu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simone.trip...@gmail.com>
Subject Re: svn commit: r963011 - /incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
Date Sun, 11 Jul 2010 11:28:00 GMT
what do you mean? can we discuss about it before committing please?
Thanks,
Simo

http://people.apache.org/~simonetripodi/
http://www.99soft.org/



On Sun, Jul 11, 2010 at 12:01 PM, Pid <pid@pidster.com> wrote:
> On 11/07/2010 09:10, simonetripodi@apache.org wrote:
>> Author: simonetripodi
>> Date: Sun Jul 11 08:10:22 2010
>> New Revision: 963011
>>
>> URL: http://svn.apache.org/viewvc?rev=963011&view=rev
>> Log:
>> minor format - tabs replaced with 4 spaces
>> removed unused imports
>>
>> Modified:
>>     incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
>
> I think we need to add the OAuthParameterLocation to the OAuthRequest
> interface signature.  I'll modify the test case in sig api at the same time.
>
>
> p
>
>> Modified: incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
>> URL: http://svn.apache.org/viewvc/incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java?rev=963011&r1=963010&r2=963011&view=diff
>> ==============================================================================
>> --- incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
(original)
>> +++ incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
Sun Jul 11 08:10:22 2010
>> @@ -17,7 +17,6 @@
>>  package org.apache.amber;
>>
>>  import java.net.URL;
>> -import java.util.Collection;
>>  import java.util.SortedSet;
>>
>>  /**
>> @@ -53,11 +52,11 @@ public interface OAuthRequest {
>>       */
>>      void addOAuthRequestParameter(OAuthRequestParameter parameter);
>>
>> -     /**
>> -      * @param signatureMethod
>> -      * @return
>> -      */
>> -     String getOAuthMessageParameter(OAuthParameter parameter);
>> +    /**
>> +     * @param signatureMethod
>> +     * @return
>> +     */
>> +    String getOAuthMessageParameter(OAuthParameter parameter);
>>
>>      /**
>>       * Returns the aux parameters client will included in the request.
>> @@ -66,10 +65,10 @@ public interface OAuthRequest {
>>       */
>>      SortedSet<OAuthRequestParameter> getOAuthRequestParameters();
>>
>> -     /**
>> -      * @param signatureMethod
>> -      * @return
>> -      */
>> -     String getOAuthRequestParameter(String name);
>> +    /**
>> +     * @param signatureMethod
>> +     * @return
>> +     */
>> +    String getOAuthRequestParameter(String name);
>>
>>  }
>>
>>
>
>
>

Mime
View raw message