oltu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pid <...@pidster.com>
Subject Re: svn commit: r962444 - /incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
Date Fri, 09 Jul 2010 09:15:44 GMT
On 09/07/2010 10:08, Simone Tripodi wrote:
> Hola!
> In the concrete implementation I thought about an Set/HashSet to
> simplify the task to maintain the parameters univocity, WDYT?

Fair point.  I wonder if we can combine this with an indication of
ordering somehow?


p

> Have a nice day,
> Simo
> 
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
> 
> 
> 
> On Fri, Jul 9, 2010 at 10:53 AM, Pid <pid@pidster.com> wrote:
>> On 09/07/2010 09:33, simonetripodi@apache.org wrote:
>>> Author: simonetripodi
>>> Date: Fri Jul  9 08:33:40 2010
>>> New Revision: 962444
>>>
>>> URL: http://svn.apache.org/viewvc?rev=962444&view=rev
>>> Log:
>>> replaced the map with collections of already defined comparable objects that
will simply the sorting task according to OAuth sorting requirements
>>
>> OK, cool.
>> It has an order, so is a List more appropriate in this case?
>>
>>
>> p
>>
>>> Modified:
>>>     incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
>>>
>>> Modified: incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
>>> URL: http://svn.apache.org/viewvc/incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java?rev=962444&r1=962443&r2=962444&view=diff
>>> ==============================================================================
>>> --- incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
(original)
>>> +++ incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/OAuthRequest.java
Fri Jul  9 08:33:40 2010
>>> @@ -17,7 +17,7 @@
>>>  package org.apache.amber;
>>>
>>>  import java.net.URL;
>>> -import java.util.SortedMap;
>>> +import java.util.Collection;
>>>
>>>  /**
>>>   * A convenient object representing the properties of an OAuth request to a
>>> @@ -34,11 +34,27 @@ public interface OAuthRequest {
>>>      HTTPMethod getHTTPMethod();
>>>
>>>      void setHTTPMethod(HTTPMethod httpMethod);
>>> -
>>> +
>>>      String getSignatureBase();
>>>
>>>      void setSignature(String signature);
>>>
>>> -    SortedMap<OAuthParameter, String> getOAuthParameters();
>>> -
>>> +    void addOAuthMessageParameter(OAuthMessageParameter parameter);
>>> +
>>> +    /**
>>> +     * Returns the OAuth parameters will be included in the OAuth message.
>>> +     *
>>> +     * @return the OAuth parameters will be included in the OAuth message.
>>> +     */
>>> +    Collection<OAuthMessageParameter> getOAuthMessageParameters();
>>> +
>>> +    void addOAuthRequestParameter(OAuthRequestParameter parameter);
>>> +
>>> +    /**
>>> +     * Returns the aux parameters client will included in the request.
>>> +     *
>>> +     * @return the aux parameters client will included in the request.
>>> +     */
>>> +    Collection<OAuthRequestParameter> getOAuthRequestParameters();
>>> +
>>>  }
>>>
>>>
>>
>>
>>



Mime
View raw message