From dev-return-9569-archive-asf-public=cust-asf.ponee.io@olingo.apache.org Tue Feb 27 15:37:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0A3CE18077B for ; Tue, 27 Feb 2018 15:37:05 +0100 (CET) Received: (qmail 94408 invoked by uid 500); 27 Feb 2018 14:37:05 -0000 Mailing-List: contact dev-help@olingo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@olingo.apache.org Delivered-To: mailing list dev@olingo.apache.org Received: (qmail 94390 invoked by uid 99); 27 Feb 2018 14:37:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2018 14:37:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 72D0AC14AA for ; Tue, 27 Feb 2018 14:37:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SKnC_SRyrVCW for ; Tue, 27 Feb 2018 14:37:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B93795F254 for ; Tue, 27 Feb 2018 14:37:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 91ECFE0A32 for ; Tue, 27 Feb 2018 14:37:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B72062411E for ; Tue, 27 Feb 2018 14:37:00 +0000 (UTC) Date: Tue, 27 Feb 2018 14:37:00 +0000 (UTC) From: "Ralf Handl (JIRA)" To: dev@olingo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OLINGO-1239) $search does not allow special characters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OLINGO-1239?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 78665#comment-16378665 ]=20 Ralf Handl edited comment on OLINGO-1239 at 2/27/18 2:37 PM: ------------------------------------------------------------- Note: the original V4 ABNF for $search was overly restrictive and only stat= ed in a comment that it was overly restrictive: {{searchWord =3D 1*ALPHA ; Actually: any character from the Unicode=C2=A0 c= ategories L or Nl,}} {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0; but not the words AND, OR, and NOT}} This mislead some implementation teams, so this was changed to {{; A searchWord is a sequence of one or more letters, digits, commas, or d= ots.}} {{ ; This includes Unicode characters of categories L or N using UTF-8 and = percent-encoding.}} {{ ; The words AND, OR, and NOT are not a valid searchWord.}} {{ ; Expressing this in ABNF is somewhat clumsy, so the following rule is o= verly generous.}} {{ searchWord =3D 1*( ALPHA / DIGIT / COMMA / "." / pct-encoded )}} See=C2=A0[http://docs.oasis-open.org/odata/odata/v4.01/cs01/abnf/odata-abnf= -construction-rules.txt] =C2=A0 was (Author: ralfhandl): Note: the original V4 ABNF for $search was overly restrictive and only stat= ed in a comment that it was overly restrictive: {{searchWord =3D 1*ALPHA ; Actually: any character from the Unicode=C2=A0 c= ategories L or Nl,}} {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0; but not the words AND, OR, and NOT}} This mislead some implementation teams, so this was changed to {quote}{\{; A searchWord is a sequence of one or more letters, digits, comm= as, or dots. }} {\{; This includes Unicode characters of categories L or N using UTF-8 and = percent-encoding. }} {\{; The words AND, OR, and NOT are not a valid searchWord. }} {\{; Expressing this in ABNF is somewhat clumsy, so the following rule is o= verly generous. }} {{searchWord =3D 1*( ALPHA / DIGIT / COMMA / "." / pct-encoded )}} {quote} See=C2=A0[http://docs.oasis-open.org/odata/odata/v4.01/cs01/abnf/odata-abnf= -construction-rules.txt] =C2=A0 > $search does not allow special characters > ----------------------------------------- > > Key: OLINGO-1239 > URL: https://issues.apache.org/jira/browse/OLINGO-1239 > Project: Olingo > Issue Type: Bug > Affects Versions: (Java) V4 4.3.0, (Java) V4 4.4.0 > Reporter: Claudia > Priority: Major > > $search does not allow to search for special chars, eg. umlauts (german = =C3=A4,=C3=B6,=C3=BC), but also other chars like $, ? should be allowed. > Root cause: SearchTokenizer checks only if a character is alphanumeric! > Workaround:=C2=A0 > Implementing a custom query option and encode the given value with encode= URIComponent() on client side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)