olingo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ramesh Reddy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OLINGO-1107) UriDecoder should use java.net.URLDecoder
Date Wed, 12 Apr 2017 16:02:41 GMT

    [ https://issues.apache.org/jira/browse/OLINGO-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966119#comment-15966119
] 

Ramesh Reddy commented on OLINGO-1107:
--------------------------------------

I believe this has been debated before, although it would be nice to have relaxed support
for "+" but %20 representation is correct form according to [1].  Olingo is known to be very
strict in parsing rules [2], which IMO could use little more relaxation in terms of client
issued urls. So, this is not a bug, but by design.

[1] http://stackoverflow.com/questions/1634271/url-encoding-the-space-character-or-20
[2] http://markmail.org/search/?q=list%3Aorg.apache.olingo.user+space#query:list%3Aorg.apache.olingo.user%20space+page:1+mid:ukiihmxuyqvunxat+state:results

> UriDecoder should use java.net.URLDecoder
> -----------------------------------------
>
>                 Key: OLINGO-1107
>                 URL: https://issues.apache.org/jira/browse/OLINGO-1107
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata4-server
>    Affects Versions: (Java) V4 4.3.0
>            Reporter: Jon McEwen
>
> Query filters are incorrectly parsed, because the org.apache.olingo.commons.core.Decoder
doesn't convert '+' to space.
> Simple fix is to use java.net.URLDecoder instead (line 85):
> {{return URLDecoder.decode(encoded, "UTF-8");}}
> Additional unit test:
> {code:Java}
>   @Test
>   public void decodePlusAsSpace() throws Exception{
> 	  checkOption("%24filter=PaymentStatus+eq+%27Cleared%27", "$filter", "PaymentStatus
eq 'Cleared'");
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message