ofbiz-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mathieu Lirzin <mathieu.lir...@nereide.fr>
Subject Re: Removing support alternate dispatcher and delegator for integration tests
Date Wed, 19 Dec 2018 11:31:23 GMT
Hello,

Since nobody has step up to discuss the rationale of having a custom
delegator/dispatcher per test, I think it is reasonable to remove this
feature.

I am going to submit the patch on Jira for review.

Mathieu Lirzin <mathieu.lirzin@nereide.fr> writes:

> We are considering removing the support for setting an alternate
> dispatcher and delegator when running integration tests.  This mechanism
> adds complexity to the way OFBiz handles those tests [1].  it isn't used
> anywhere in the framework but maybe some users relies on it elsewhere.
>
> If you are concerned it is time to step up and discuss the rationale of
> its usage, and maybe consider alternatives.
>
> Here is the precise change which is considered to be applied in OFBiz:
>
> From 66150cc98d2b7b84ee5aa4dee1e25f60556577e6 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mathieu.lirzin@nereide.fr>
> Date: Sun, 21 Oct 2018 16:02:38 +0200
> Subject: [PATCH] Disallow using alternate dispatcher and delegator for
>  integration tests
>
> ---
>  framework/testtools/dtd/test-suite.xsd        |  2 --
>  .../ofbiz/testtools/ModelTestSuite.java       | 23 +++++--------------
>  2 files changed, 6 insertions(+), 19 deletions(-)

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Mime
View raw message