ofbiz-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacques Le Roux <jacques.le.r...@les7arts.com>
Subject Re: Proposal: Use of single label for input fields
Date Mon, 25 Sep 2017 16:11:32 GMT
We sometimes use <fieldset> in Freemarker file and we have the <field-group> related
thing in widget form (eg see 
https://demo-trunk.ofbiz.apache.org/catalog/control/EditProduct?productId=GZ-1000)

IMO <field-group> should be used there and alike forms

Jacques


Le 25/09/2017 à 16:11, Kenneth Paskett a écrit :
> Hello -
>
> In reviewing the markup around this code, I see that we are just using
> <td>s with a <label>. When grouping related fields in a form, shouldn't we
> be using <fieldset> <https://www.w3schools.com/TAgs/tag_fieldset.asp>
> around the group of input and label tags, and then use the <legend> tag to
> describe what the grouping is? If no box is desired around the fieldset,
> CSS can be used to remove it.
>
> ~Kenneth
>
> On Sat, Sep 23, 2017 at 8:46 PM Sanjay Yadav <sanjay.yadav@hotwaxsystems.com>
> wrote:
>
>> +1. Good catch, Garima.
>>
>> Best Regards,
>>
>> *Sanjay Yadav* | Manager, Enterprise Quality Assurance
>> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
>> <http://www.hotwaxsystems.com/>
>> 80, Scheme No. 78, Part II, Indore, M.P. 452010, India
>> Mobile Phone: 787 918 8830 <(787)%20918-8830> | Linkedin: Sanjay-Yadav
>> <https://www.linkedin.com/in/sanjay-yadav/>
>>
>> HotWax Systems recently received 8 mentions in *The Gartner Digital
>> Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
>> research and advisory company. Learn more about our research here
>> <https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html>
>> .
>> [image: Inline image 1]
>>
>>
>>
>> On Sat, Sep 23, 2017 at 5:56 PM, Garima Jain <jaingarima2094@gmail.com>
>> wrote:
>>
>>> Hello Devansu,
>>>
>>> I have seen in many screens this kind of practice followed in OFBiz mostly
>>> for the Email Address fields.
>>> I have created the ticket for the same. Below is the link,
>>>
>>> https://issues.apache.org/jira/browse/OFBIZ-9769
>>>
>>> On Sat, Sep 23, 2017 at 4:59 PM, Devanshu Vyas <vyas.devanshu16@gmail.com
>>> wrote:
>>>
>>>> Hello Garima,
>>>>
>>>> Good Catch! But I feel that this is a bug, not a designing practice(I
>>>> hope).
>>>> You should create a JIRA ticket for the same and if you find multiple
>>>> occurrences of this kind of labels, then all can be fixed under it.
>>>>
>>>> If this is some kind of practice used in OFBiz, then I agree with you
>>> and
>>>> we should not use titles for it.
>>>> Looking forward to your reply.
>>>>
>>>>
>>>>
>>>>
>>>> Thanks & Regards,
>>>> Devanshu Vyas.
>>>>
>>>> On Sat, Sep 23, 2017 at 4:43 PM, Garima Jain <jaingarima2094@gmail.com>
>>>> wrote:
>>>>
>>>>> Hello Jacques,
>>>>>
>>>>> I want to explain if there are multiple input fields and all belong to
>>>> same
>>>>> group/category(like address1, address2, city and state input fields
>>>> belong
>>>>> to Address category) in a form then we can use a title for such type
>>> of
>>>>> categories. But, if there is only a single field (like Email address
>>> has
>>>>> single input field) then we should not use the title for it.
>>>>>
>>>>> I am also sharing the link of google drive which contains screenshot
>>> with
>>>>> detailed explanation.
>>>>>
>>>>> https://drive.google.com/file/d/0B6et9_lt0zGVY3pXV2tmVmhtUjA/view?
>>>>> usp=sharing
>>>>>
>>>>> Hope this Helps!
>>>>>
>>>>> On Sat, Sep 23, 2017 at 3:37 PM, Jacques Le Roux <
>>>>> jacques.le.roux@les7arts.com> wrote:
>>>>>
>>>>>> Hi Garima,
>>>>>>
>>>>>> Sorry but I don't understand what you want to do, could you please
>>> give
>>>>> us
>>>>>> more details
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 23/09/2017 à 11:45, Garima Jain a écrit :
>>>>>>
>>>>>>> Hello,
>>>>>>>
>>>>>>> In OFBiz, some of the forms have a common group label that binds
a
>>>>> certain
>>>>>>> set of input elements together under a group, like,
>>>>>>>
>>>>>>>
>>>>>>> *Shipping Address*
>>>>>>>
>>>>>>>      - Address 1
>>>>>>>      - Address 2
>>>>>>>      - City
>>>>>>>      - State
>>>>>>>
>>>>>>> This is okay when we have multiple input fields in a group. But,
in
>>>> case
>>>>>>> of
>>>>>>> independent fields, there must be a single label that describes
the
>>>>> field.
>>>>>>> like Email and its Input field.
>>>>>>>
>>>>>>> Here is the reference
>>>>>>>
>>>>>>> https://demo-trunk.ofbiz.apache.org/sfa/control/NewLead
>>>>>>>
>>>>>>>
>>>>>>> *Kind Regards*
>>>>>>> Garima Jain
>>>>>>>
>>>>>>>
>>>>>
>>>>> *Kind Regards*
>>>>> Garima Jain
>>>>> ​Enterprise software Engineer
>>>>> Hotwax Systems​
>>>>>
>>


Mime
View raw message