Mailing-List: contact user-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@ofbiz.apache.org
Received-SPF: pass (athena.apache.org: domain of chunlinyao@gmail.com
 designates 209.85.192.175 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: Should we use some lock when update qoh of InventoryItem
From: YaoCL <chunlinyao@gmail.com>
In-Reply-To: <53E1CED4.3090909@sandglass-software.com>
Date: Wed, 6 Aug 2014 15:08:57 +0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <F5F83AE8-DB16-49DA-A34C-5369B332728B@gmail.com>
References: <E0E616F2-2715-4E43-977C-89A432224E0F@gmail.com>
 <53E1C005.2040508@sandglass-software.com>
 <CALboGQ21-pWJCq4Ce6m6XLSmaCbwKAL6AUTNYPYv-1P=PsK62w@mail.gmail.com>
 <53E1CED4.3090909@sandglass-software.com>
To: user@ofbiz.apache.org

Did you mean storeByCondition method. With it I must check the updated =
row count, if equals 0 retry again. SELECT FOR UPDATE will block one =
transaction to wait until the end of another transaction.

On Wed, Aug 06, 2014 at 14:44, Adrian Crum =
<adrian.crum@sandglass-software.com> Wrote:
>=20
> The entity engine supports updates that include a WHERE clause - so it =
would be possible to update only when the lastUpdatedStamp matches.
>=20
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>=20
> On 8/6/2014 7:31 AM, Yaocl wrote:
>> I can only consider a solution use SELECT FOR UPDATE,  lock the
>> inventory item then SELECT ... sum(...) FROM inventory_item_detail
>> GROUP BY ...., then update the inventory item. But it seems
>> EntityEngine not support FOR UPDATE.
>> --
>> YaoCL
>>=20
>> On Wed, Aug 6, 2014 at 1:41 PM, Adrian Crum
>> <adrian.crum@sandglass-software.com> wrote:
>>> This has been discussed on the dev mailing list, and there are =
differing
>>> opinions. I agree this is a bug and should be fixed, but others =
believe it
>>> is highly unlikely two people will be modifying the same invoice at =
the same
>>> time - so it is not a problem.
>>>=20
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>>=20
>>>=20
>>> On 8/6/2014 3:01 AM, YaoCL wrote:
>>>>=20
>>>> Hi,
>>>>=20
>>>> When create a new InventoryItemDetail the InventoryItem will be =
updated by
>>>> eeca. But If two threads create InventoryItemDetails =
simultaneously. Because
>>>> we use ReadCommitted Isolation level, Neither will see =
InventoryItemDetails
>>>> created by other threads before transaction commit.
>>>> updateInventoryItemFromDetail service will get incorrect qoh, and
>>>> InventoryItem will be updated. Two threads will all be committed
>>>> successfully.
>>>>=20
>>>> I can confirm the behavior by set a breakpoint in
>>>> org.ofbiz.minilang.method.entityops.StoreValue.exec(MethodContext) =
to
>>>> emulate above process. The result can be checked by this SQL.
>>>>=20
>>>> select * from inventory_item t1 left join (
>>>> select inventory_item_id, sum(quantity_on_hand_diff) as qoh,
>>>> sum(available_to_promise_diff) as atp from inventory_item_detail
>>>> group by inventory_item_id) t2 on t1.inventory_item_id =3D
>>>> t2.inventory_item_id
>>>> where t1.quantity_on_hand_total <> t2.qoh;
>>>>=20
>>>> =E2=80=94
>>>> YaoCL
>>>>=20
>>>=20