Mailing-List: contact user-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@ofbiz.apache.org
Received-SPF: pass (athena.apache.org: domain of bruno.busco@gmail.com
 designates 209.85.200.170 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=Wecfl6j6CoOk2g3Ye7ukBA2ijzILj5tAoTONIHdHHUvHXggzo33zPpiwbsWCoeZY2uvCC1T0DHaJdCQdsexrbn6AoWAUZt0YbhggaH+VuPqDHByNm4K2M9GJpdBAhwkn/lsLQ6VkPdn6AGsN9Dp8qn1tIpItzoOAiQB41z0ZZJE=
Message-ID: <f7554a950803031413l2420b5c6g8ce4430ae3d212be@mail.gmail.com>
Date: Mon, 3 Mar 2008 23:13:58 +0100
From: "Bruno Busco" <bruno.busco@gmail.com>
To: user@ofbiz.apache.org
Subject: Re: Multiple UiLabels definitions
In-Reply-To: <47CC2008.1030704@hlmksw.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_6212_26654208.1204582438158"
References: <f7554a950803021512w4fef6b4ei64fe068f213a1cd2@mail.gmail.com>
	 <47CC2008.1030704@hlmksw.com>

------=_Part_6212_26654208.1204582438158
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

2008/3/3, Adrian Crum <adrianc@hlmksw.com>:
>
> Bruno Busco wrote:
> > Hi,
> > while testing ecommerce application i have found that selecting the
> ITalian
> > language, some labels are displayed still in english.
> > I was convinced that this was because of a missing translation but the
> > reason was a little different:
> >
> > Some labels are defined in more than one resource file. For example
> > "CommonQuickAdd" is both in EcommerceUiLabels.xml and in
> > CommonUiLabels.xmlfiles.
> > But while the CommonUiLabels.xml is complete, in the
>
> > EcommerceUiLabels.xmlfile there is no italian label.
>
> >
> > So what I think that could happen is that OFBiz tries to have an IT
> string
> > from the EcommerceUiLabels.xml file (the first one), this is not found
> and
> > so it falls back to what is specified in (locale.properties.fallback=en)
> > BEFORE checking if the IT string is present in other resource files.
> >
> > I tryed to delete the incomplete <property key="CommonQuickAdd"> from
> the
> > EcommerceUiLabels.xml and now the italian string is correctly displayed
> > (because no fallback).
> > Also defining (locale.properties.fallback=it) it works because now, even
> the
> > CommonUiLabels.xml is looked for an italian string.
> >
> > I see four options for me to solve the problem:
> > 1) Add all italian strings to EcommerceUiLabels.xml even if they are
> already
> > present in CommonUiLabels.xml (I don't like because of redundancy)
> > 2) Remove all the Common*** labels from EcommerceUiLabels.xml (any
> > drawbacks?)
> > 3) Change to (locale.properties.fallback=it)
>
>
> #3 will generate "resource not found" errors. In effect you would be
> saying "If you can't find the IT label, then fall back to the IT label."
>
>
> -Adrian
>

OK. I have removed all Common* labels that are defined in
CommonUiLabels.xmlfile from all the other files and it seems to work
now.
But this is not enough because for instance EcommerceYourShoppingCartEmpty
label is present both in ECommerceUiLabels.xml AND in OrderUiLabels.xml.
Should I remove the occurrence of this label from OrderUiLabels.xml ?
In other words what is the naming convention to be observed?
Could I follow the rule that all the labels that starts with AppName must be
only defined in the AppNameUiLabels.xml file?

Bruno

------=_Part_6212_26654208.1204582438158--