From notifications-return-32086-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Sun Mar 8 10:00:04 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6C60E180634 for ; Sun, 8 Mar 2020 11:00:04 +0100 (CET) Received: (qmail 59202 invoked by uid 500); 8 Mar 2020 10:00:03 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 59191 invoked by uid 99); 8 Mar 2020 10:00:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Mar 2020 10:00:03 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5D014E2E0A for ; Sun, 8 Mar 2020 10:00:02 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id AE96178085F for ; Sun, 8 Mar 2020 10:00:01 +0000 (UTC) Date: Sun, 8 Mar 2020 10:00:01 +0000 (UTC) From: "Pierre Smits (Jira)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-10407) create a docker image from the ofbiz system MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-10407?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D170= 54356#comment-17054356 ]=20 Pierre Smits commented on OFBIZ-10407: -------------------------------------- Thank you, [~mbrohl], for your feedback. * Re "we should use the Adopt Open JDK as listed in the requirements" The readme.adoc in the repository on Github states ??The only requirement to run OFBiz is to have the Java Development Kit (JD= K) version 8 installed on your system?? and provides a link to an advised download location. However, many Linux di= stros (including Ubuntu) provide OpenJDK binaries ready to use. So there is= no need to do it differently; * Re "xplicit Java installation can be removed by directly selecting the ri= ght Adopt Open JDK Docker image" The Adopt Open JDK Docker image puts the OpenJDK code at a different locati= on than what is grown a defacto standard in Linux distros. We should not fo= llow this approach. * Re "he used Ubuntu is outdated, we should use the 18.04 LTS release" This has been corrected in an update to the PR * Re "what about the Apache Yetus comment, seems to belong to another Docke= r image?" This has been corrected in an update to the PR * Re "the setup seems to add/install more than is needed" Proposed Dockerfile is intended for testing and evaluation purposes, not fo= r running a production setup where some of the added packages may not be de= sired. For now, I suggest to go with it as it is. Regarding your other thoughts on using Dockerfiles for releases and moving = it outside of the codebase. A release where this is incorporated is still far into future. But you're c= orrect: before we arrive on that moment this should be addressed. However, = mature projects (visavis generating docker images) tend to have a CI proces= s in play that ensures that images generated automatically use the code bas= ed on either branch or tag. We're not there yet.=20 Having Dockerfile outside of the codebase has some negative side effects: * we add additional complexity which needs to be communicated and maintaine= d * we add additional complexity in CI processes For now I suggest the projects goes with this as it is, and as it matures i= t can decide where the favourable location should be. > create a docker image from the ofbiz system > ------------------------------------------- > > Key: OFBIZ-10407 > URL: https://issues.apache.org/jira/browse/OFBIZ-10407 > Project: OFBiz > Issue Type: Improvement > Affects Versions: Trunk > Reporter: Hans Bakker > Priority: Major > Labels: DevOps > Attachments: docker.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Attached an initial docker version from OFBiz copied from our GrowERP pro= duction system translated to svn repositories. > I propose to create a docker directory in the ofbiz framework root of whi= ch a patch is attached. > The image result is stored in hub.docker.com under the name ofbiz/full-tr= unk. > It can be started in a docker environment with the following command: > docker run -p 80:8080 -p 443:8443 ofbiz/full-trunk > and after about 30 seconds it can be show in the browser under: > [https://0.0.0.0/catalog/control/main] > =C2=A0the image can be created by executing this command in the ofbiz roo= t when the patch is applied: > docker build -t ofbiz/full-trunk docker > the password to the ofbiz account at hub.docker.com will be supplied upon= request. > =C2=A0 > see the discussion in the mailinglist at https://markmail.org/message/n7w= cgroslj7v3gfe?q=3Ddocker+ofbiz > =C2=A0 -- This message was sent by Atlassian Jira (v8.3.4#803005)