ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11448) Potential Nullpointer in ErrorPage.ftl
Date Tue, 10 Mar 2020 15:07:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056032#comment-17056032
] 

ASF subversion and git services commented on OFBIZ-11448:
---------------------------------------------------------

Commit 0c7be39acb089433a252adf9f34ed72ab34654d2 in ofbiz-framework's branch refs/heads/release17.12
from Dennis Balkir
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0c7be39 ]

Fixed: Potential Nullpointer in ErrorPage.ftl

(OFBIZ-11448)

Inserted nullcheck for request-attribute

> Potential Nullpointer in ErrorPage.ftl
> --------------------------------------
>
>                 Key: OFBIZ-11448
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11448
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>            Reporter: Dennis Balkir
>            Assignee: Michael Brohl
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This line of code right here:
> {code:java}
> <p>${request.getAttribute("_ERROR_MESSAGE_")?replace("\n", "<br/>")}</p>
> {code}
> can produce a nullpointer error, since the attribute "_ERROR_MESSAGE_" from the request
ist used by the replace method of freemarker, without nullchecking it first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message