ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
Date Mon, 09 Mar 2020 13:03:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054933#comment-17054933
] 

Michael Brohl edited comment on OFBIZ-11030 at 3/9/20, 1:02 PM:
----------------------------------------------------------------

[~sberg] I think the latest patch needs more refactoring to be more "groovyish", e.g. replace
the UtilValidate.isEmpty with the appropriate Groovy checks. See the reviews from Nicolas
in other Jiras.


was (Author: mbrohl):
[~sberg]I think the latest patch needs more refactoring to be more "groovyish", e.g. replace
the UtilValidate.isEmpty with the appropriate Groovy checks. See the reviews from Nicolas
in other Jiras.

> Convert FactServices.xml minilang to groovy
> -------------------------------------------
>
>                 Key: OFBIZ-11030
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11030
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: bi
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Sebastian Berg
>            Priority: Major
>              Labels: Fact, dwh, services
>         Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-InventoryItemFact-DemoTrunk.png,
OFBIZ-11030-InventoryItemFact-test.png, OFBIZ-11030-Order-SalesOrder-overview.png, OFBIZ-11030-SalesInvoiceItemFact-test.png,
OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert FactServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message